Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error resolving host and basepath #475

Merged
merged 1 commit into from
Jul 26, 2019
Merged

fix: error resolving host and basepath #475

merged 1 commit into from
Jul 26, 2019

Conversation

ubogdan
Copy link
Contributor

@ubogdan ubogdan commented Jul 25, 2019

Describe the PR
fix issue 474
fix issue 461
repair case tests

Relation issue
#474
#461

Additional context

@codecov-io
Copy link

codecov-io commented Jul 25, 2019

Codecov Report

Merging #475 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #475      +/-   ##
==========================================
- Coverage    86.6%   86.58%   -0.02%     
==========================================
  Files           7        7              
  Lines        1560     1558       -2     
==========================================
- Hits         1351     1349       -2     
  Misses        120      120              
  Partials       89       89
Impacted Files Coverage Δ
parser.go 81.07% <100%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67075e4...689a107. Read the comment docs.

Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but this changes I'm not sure does it work for programmatically value passing? I think we could add the test for it.

@ubogdan
Copy link
Contributor Author

ubogdan commented Jul 25, 2019

This change fix annoying {{.Host}} and {{.BasePath}} into json/yaml files. I have no clue what other tests you are suggesting to add.

The issue was introduced

commit 7b8e2c6e9410cb72361a377c8e2f0925201317cf 
Author: Bojan 
Date: 10/2/18 5:20 AM  feat: add mechanism to programatically set general api info (#220)

@ubogdan
Copy link
Contributor Author

ubogdan commented Jul 25, 2019

I've left some comments on issue itself. Anyway if you don't like it just refuse the PR.

@easonlin404
Copy link
Member

It’s ok for me. I would check later and add the tests if necessary.

@easonlin404 easonlin404 changed the title issue: support anonymous nested structure slice parsing fix: error resolving host and basepath Jul 26, 2019
Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@easonlin404 easonlin404 merged commit c19280e into master Jul 26, 2019
@easonlin404 easonlin404 deleted the fix-issue-474 branch July 26, 2019 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants