Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed JSON issue with Multiline API Description #481

Merged

Conversation

lonnblad
Copy link
Contributor

Describe the PR
Fixed an issue where the JSON breaks when programmatically setting a Multiline API Description.

Relation issue
#480

@codecov-io
Copy link

codecov-io commented Jul 29, 2019

Codecov Report

Merging #481 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #481   +/-   ##
=======================================
  Coverage   86.58%   86.58%           
=======================================
  Files           7        7           
  Lines        1558     1558           
=======================================
  Hits         1349     1349           
  Misses        120      120           
  Partials       89       89
Impacted Files Coverage Δ
gen/gen.go 89.65% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c19280e...5c2a121. Read the comment docs.

Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please replace strings.ReplaceAll with strings.Replace .

Replace all was introduced in go 1.12 and will break compatibility with older go versions.

Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ubogdan ubogdan merged commit c2f6613 into swaggo:master Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants