Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs.go test coverage #482

Merged
merged 3 commits into from
Jul 30, 2019
Merged

docs.go test coverage #482

merged 3 commits into from
Jul 30, 2019

Conversation

ubogdan
Copy link
Contributor

@ubogdan ubogdan commented Jul 29, 2019

Describe the PR
Add code coverage for generated docs.go

Relation issue
None

Additional context
There is 0% coverage for any of the docs.go generated files.

@codecov-io
Copy link

codecov-io commented Jul 29, 2019

Codecov Report

Merging #482 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #482   +/-   ##
=======================================
  Coverage   86.58%   86.58%           
=======================================
  Files           7        7           
  Lines        1558     1558           
=======================================
  Hits         1349     1349           
  Misses        120      120           
  Partials       89       89

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2f6613...548f637. Read the comment docs.

@ubogdan ubogdan requested a review from easonlin404 July 29, 2019 12:45
Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@easonlin404 easonlin404 merged commit 77b9020 into master Jul 30, 2019
@easonlin404 easonlin404 deleted the coverage-dev branch July 30, 2019 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants