Add generated time flag #501
Conversation
Codecov Report
@@ Coverage Diff @@
## master #501 +/- ##
==========================================
+ Coverage 86.36% 86.38% +0.01%
==========================================
Files 7 7
Lines 1614 1616 +2
==========================================
+ Hits 1394 1396 +2
Misses 136 136
Partials 84 84
Continue to review full report at Codecov.
|
|
IMO, you should add a generatedTime flag with a true default. I don’t like negative options, but maybe that’s just me. |
xizhibei
force-pushed
the
generation-time-flag
branch
2 times, most recently
from
53411c3
to
189bdae
Compare
|
Yes, I did not find the |
gen/gen_test.go
Outdated
| @@ -230,7 +230,7 @@ func TestGen_writeGoDoc(t *testing.T) { | |||
| swapTemplate := packageTemplate | |||
|
|
|||
| packageTemplate = `{{{` | |||
| err := gen.writeGoDoc(nil, nil) | |||
| err := gen.writeGoDoc(nil, nil, nil) | |||
There was a problem hiding this comment.
could you and the new test cases having pass by configuration?
|
@xizhibei , any update here ? |
|
Waiting for @easonlin404 reply, but I can make the test code update first |
xizhibei
force-pushed
the
generation-time-flag
branch
from
c8ce0ac
to
a66c414
Compare
|
Looking forward to having this in a release 👍 |
|
Eagerly awaiting this as well! When code generation commands are idempotent, it really helps reduce churn and noise in repositories, and the reproducibility of output makes builds more scriptable. |
|
sorry for the late reply. @xizhibei can you help fix conflicting files if you have free time? Rest LGTM. |
xizhibei
force-pushed
the
generation-time-flag
branch
from
a66c414
to
7955f5e
Compare
|
Thanks for contributing. |
Describe the PR
Add generation time flag, as described below in #488
Relation issue
#488
Additional context