Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required tag doesn't work with nested object property #504 #541

Merged
merged 6 commits into from
Oct 25, 2019

Conversation

takushi-m
Copy link
Contributor

Relation issue
#504

@codecov-io
Copy link

codecov-io commented Oct 15, 2019

Codecov Report

Merging #541 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #541      +/-   ##
==========================================
+ Coverage    87.2%   87.24%   +0.04%     
==========================================
  Files           7        7              
  Lines        1555     1560       +5     
==========================================
+ Hits         1356     1361       +5     
  Misses        117      117              
  Partials       82       82
Impacted Files Coverage Δ
parser.go 82.03% <100%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab69c23...c76f50a. Read the comment docs.

Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@easonlin404
Copy link
Member

@takushi-m Thanks for your contributions. 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants