Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize getArrayPropertyName; support [][]string fixing #562 #588

Merged
merged 2 commits into from
Dec 25, 2019
Merged

optimize getArrayPropertyName; support [][]string fixing #562 #588

merged 2 commits into from
Dec 25, 2019

Conversation

sdghchj
Copy link
Member

@sdghchj sdghchj commented Dec 23, 2019

optimize getArrayPropertyName;
support [][]string fixing bug mentioned by #562, also #510

@codecov-io
Copy link

codecov-io commented Dec 23, 2019

Codecov Report

Merging #588 into master will decrease coverage by 0.16%.
The diff coverage is 85.29%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #588      +/-   ##
=========================================
- Coverage   86.36%   86.2%   -0.17%     
=========================================
  Files           7       7              
  Lines        1614    1631      +17     
=========================================
+ Hits         1394    1406      +12     
- Misses        136     141       +5     
  Partials       84      84
Impacted Files Coverage Δ
parser.go 80.89% <100%> (+0.28%) ⬆️
property.go 93.75% <75%> (-6.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e5dd7d...09b1c26. Read the comment docs.

Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@easonlin404 easonlin404 merged commit 10630b9 into swaggo:master Dec 25, 2019
@easonlin404
Copy link
Member

@sdghchj Thanks for your contributions. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants