Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect optional output directory in the generated docs.go #617

Merged
merged 1 commit into from
Jan 24, 2020

Conversation

bruceadowns
Copy link
Contributor

@bruceadowns bruceadowns commented Jan 23, 2020

Describe the PR
The swag cli optionally provides output directory that defaults to docs/. This PR will ensure that if the default is overridden, it will be reflected in the generated docs.go output.

Relation issue
na

Additional context
This PR also includes miscellaneous spelling and goimports corrections.

@codecov-io
Copy link

codecov-io commented Jan 23, 2020

Codecov Report

Merging #617 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #617      +/-   ##
==========================================
+ Coverage   85.82%   85.84%   +0.02%     
==========================================
  Files           7        7              
  Lines        1693     1696       +3     
==========================================
+ Hits         1453     1456       +3     
  Misses        150      150              
  Partials       90       90
Impacted Files Coverage Δ
gen/gen.go 96.82% <100%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87eac7e...125baac. Read the comment docs.

Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@easonlin404 easonlin404 merged commit 51a9215 into swaggo:master Jan 24, 2020
@easonlin404
Copy link
Member

@bruceadowns Thanks for your contributions. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants