Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate to using/urfave/cli/v2 #618

Merged
merged 9 commits into from
Feb 1, 2020
Merged

Conversation

xiaodiannao
Copy link
Contributor

Describe the PR
go get -u github.com/swaggo/swag/cmd/swag results in some errors because the https://github.com/urfave/cli implementation changed.

Snippet of the error message:

../github.com/swaggo/swag/cmd/swag/main.go:25:16: cannot use cli.StringFlag literal (type cli.StringFlag) as type cli.Flag in array or slice literal:
	cli.StringFlag does not implement cli.Flag (Apply method has pointer receiver)
../github.com/swaggo/swag/cmd/swag/main.go:30:16: cannot use cli.StringFlag literal (type cli.StringFlag) as type cli.Flag in array or slice literal:
	cli.StringFlag does not implement cli.Flag (Apply method has pointer receiver)
../github.com/swaggo/swag/cmd/swag/main.go:35:16: cannot use cli.StringFlag literal (type cli.StringFlag) as type cli.Flag in array or slice literal:
	cli.StringFlag does not implement cli.Flag (Apply method has pointer receiver)

Additional context
Sorry for the number of commits, I edited directly on GitHub.

Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you help change:

  • imported github.com/urfave/cli to github.com/urfave/cli/v2
  • executed go mod tidy and commited go.mod file

That will be work for this change. 😄

@easonlin404 easonlin404 changed the title Fixing go get feat: migrate to using/urfave/cli/v2 Jan 31, 2020
@codecov-io
Copy link

codecov-io commented Jan 31, 2020

Codecov Report

Merging #618 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #618   +/-   ##
=======================================
  Coverage   85.84%   85.84%           
=======================================
  Files           7        7           
  Lines        1696     1696           
=======================================
  Hits         1456     1456           
  Misses        150      150           
  Partials       90       90

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51a9215...6b366f6. Read the comment docs.

@xiaodiannao
Copy link
Contributor Author

Hi @easonlin404 thank you for your reply I updated it, now the checks are passing

Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@easonlin404 easonlin404 merged commit 86e76b7 into swaggo:master Feb 1, 2020
@easonlin404 easonlin404 mentioned this pull request Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants