Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support colletionFormat for array params in query; Exclude directories and files #642

Merged
merged 13 commits into from
Mar 22, 2020

Conversation

sdghchj
Copy link
Member

@sdghchj sdghchj commented Mar 14, 2020

Describe the PR
feature: support collectionFormat for array params in query.
feature: use flag -exclude to exclude directories and files when searching APIs.
Fix bug: can't find dependent packages when running on windows and both --dir and --parseDependency are set.

Relation issue
#636 #640

@sdghchj sdghchj changed the title Support colletionFormat for array params in query Support colletionFormat for array params in query; Exclude directories and files Mar 15, 2020
@codecov-io
Copy link

codecov-io commented Mar 15, 2020

Codecov Report

Merging #642 into master will decrease coverage by 0.82%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #642      +/-   ##
==========================================
- Coverage   85.74%   84.91%   -0.83%     
==========================================
  Files           7        7              
  Lines        1726     1757      +31     
==========================================
+ Hits         1480     1492      +12     
- Misses        154      169      +15     
- Partials       92       96       +4     
Impacted Files Coverage Δ
parser.go 79.91% <38.88%> (-0.72%) ⬇️
operation.go 89.13% <50.00%> (-1.34%) ⬇️
schema.go 96.61% <66.66%> (-3.39%) ⬇️
gen/gen.go 96.85% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e8a052...1391346. Read the comment docs.

easonlin404
easonlin404 previously approved these changes Mar 17, 2020
Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@easonlin404
Copy link
Member

@swaggo/swaggo-core-team please help review it, thanks.

@easonlin404 easonlin404 requested a review from a team March 17, 2020 02:49
@easonlin404 easonlin404 merged commit 2f74ff2 into swaggo:master Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants