Fix train_model.py bug, fix Analysis module import

[smericks]

• Fix bug for params_as_inputs in train_model.py
• Fix relative import in train_model.py
• Fix import of Analysis module in init.py

[smericks]

@swagnercarena I tried to reproduce the failed test (test_plot_coverage() in analysis tests), but I'm passing all tests on my machine. Any idea what's causing this?

[JelleAalbers]

Looks good Sydney, thanks for fixing! Maybe you'd like to do if params_as_inputs instead of if len(params_as_inputs) > 0; that's slightly more concise and avoids crashing on values like None or False (though I don't see how those could easily arise in this code).

I saw the same test failure; I think it is due to a new matplotlib version. So we'd see the same on master if we were to redo the build there. #38, and in particular 94bfd3d, will fix this.

[smericks]

Yes I agree that's a cleaner way to do it, I just made that change.

Ok I see, glad there's a fix on the way!

[JelleAalbers]

Thanks Sydney!

[JelleAalbers]

@swagnercarena Do you agree this is good to merge? Sorry, I should have asked you explicitly before approving.

[coveralls]

Pull Request Test Coverage Report for Build 3285470493

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.03%) to 95.044%

---

Totals
Change from base Build 2702188126:	-0.03%
Covered Lines:	2282
Relevant Lines:	2401

---

💛 - Coveralls

[swagnercarena]

Thanks for making these additions @smericks. I went ahead and included @JelleAalbers fix so that we didn't get failures on the main page (I also included a 0.1 decrease coverage threshold for failure since the 0% threshold was too strict).