Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added delete account feature #252

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

coding-geek21
Copy link
Contributor

Related Issue or bug

added delete account feature

Fixes: #242

Describe the changes you've made

User will be able to delete the account after login using delete account option , this also deletes the contacts saved under the user

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots

Original Updated
original screenshot updated screenshot
13.04.2021_12.02.30_REC.mp4

@coding-geek21
Copy link
Contributor Author

@swapnilsparsh Please review this PR, Thank you!

@swapnilsparsh
Copy link
Owner

@coding-geek21 Great work but I want you to add this feature to profile section which is in development rather than adding it to navbar.
@sakshikhachane What's your POV ?

@sakshikhachane
Copy link
Collaborator

sakshikhachane commented Apr 15, 2021

@swapnilsparsh I also feel the same. But I think we can ask the assignee of issue #194 to integrate this feature in the profile section as she hasn't created the PR for now.

@sakshikhachane sakshikhachane added gssoc21 GirlScript Summer of Code 2021 Level3 New features, major bug fixing. labels Apr 15, 2021
@SnehaVeerakumar
Copy link

This looks cool. I will surely consider this. By today I will make a PR and I can look into this feature too ! @sakshikhachane @swapnilsparsh
Most probably I will add this feature too while making a PR for #194 issue.

@coding-geek21
Copy link
Contributor Author

coding-geek21 commented Apr 16, 2021

@coding-geek21 Great work but I want you to add this feature to profile section which is in development rather than adding it to navbar.
@sakshikhachane What's your POV ?

@swapnilsparsh I will wait for #194 to get merged and add this feature there or get this merged so that person working on #194 issue can integrate it while making PR, Anything is fine for me

@SnehaVeerakumar
Copy link

I guess after merging my PR, you can create separate issue and make a PR. I guess that would be fine @swapnilsparsh

@swapnilsparsh swapnilsparsh merged commit 74e360a into swapnilsparsh:master Apr 30, 2021
@github-actions
Copy link

Thank you @coding-geek21 for your contribution. Looking forward for more such amazing contributions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc21 GirlScript Summer of Code 2021 Level3 New features, major bug fixing. ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deletion of user account
5 participants