Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show duplicate robot logs #1022

Merged
merged 5 commits into from Jan 24, 2023
Merged

Show duplicate robot logs #1022

merged 5 commits into from Jan 24, 2023

Conversation

xsebek
Copy link
Member

@xsebek xsebek commented Jan 21, 2023 •
edited

  • show duplicate robot logs in the log view
  • make the log a tangible short command, like say
  • fixup tests
    • Use meetAll to make crash tutorial more resilient
    • Account for log in wait-one test
    • Remove log from farming solution to fix timing
  • closes Logs are getting alphabetically sorted #1021

@xsebek
Show duplicit robot logs
976d8d6 
- show duplicit robot logs in the log view
- make log a tangible short command, like say
-closes #1021
@xsebek
Copy link
Member Author

xsebek commented Jan 21, 2023

Oh great, it looks like a few tests depended on the log being intangible. 🙄

@xsebek xsebek requested a review from byorgey January 21, 2023 19:01
@byorgey
Copy link
Member

byorgey commented Jan 21, 2023

it looks like a few tests depended on the log being intangible.

Hah, oops.

@xsebek xsebek added the merge me Trigger the merge process of the Pull request. label Jan 24, 2023
@mergify mergify bot merged commit 07673d1 into main Jan 24, 2023
@xsebek xsebek deleted the duplicit-log branch January 24, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byorgey byorgey byorgey approved these changes

Assignees
No one assigned
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Logs are getting alphabetically sorted
2 participants
@xsebek @byorgey