Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

device for setname #1028

Merged
merged 3 commits into from Jan 23, 2023
Merged

device for setname #1028

merged 3 commits into from Jan 23, 2023

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented Jan 23, 2023

Towards #26

@kostmo kostmo requested review from byorgey and xsebek January 23, 2023 02:57
@kostmo kostmo marked this pull request as ready for review January 23, 2023 02:57
xsebek
xsebek approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@xsebek xsebek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice pun. 👍

Can you add a recipe too please? Preferably not silver, since there is not much power in setname and it could be a bit dissapointing. 😅

@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label Jan 23, 2023
@mergify mergify bot merged commit 7fd2a1c into main Jan 23, 2023
@mergify mergify bot deleted the setname-device branch January 23, 2023 09:07
@byorgey byorgey mentioned this pull request Jan 24, 2023
Closed
21 tasks
@kostmo kostmo mentioned this pull request Apr 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xsebek xsebek xsebek approved these changes

@byorgey byorgey Awaiting requested review from byorgey

Assignees
No one assigned
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kostmo @xsebek