Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requirements command for viewing requirements of any expression #1183

Merged
merged 13 commits into from Apr 2, 2023
Merged

requirements command for viewing requirements of any expression #1183

merged 13 commits into from Apr 2, 2023

Conversation

byorgey
Copy link
Member

@byorgey byorgey commented Mar 27, 2023 •
edited

Add a special built-in command requirements which can be applied to any expression. Typing requirements e at the REPL will cause a log message to be generated listing the requirements for the given expression. For example, requirements (move; grab) generates

Requirements for `(move; grab)`:
  Equipment:
    - fast grabber OR grabber OR harvester
    - solar panel
    - tank treads OR treads

Closes #922 .

@byorgey byorgey marked this pull request as ready for review March 29, 2023 02:32
@byorgey byorgey requested review from xsebek and kostmo March 29, 2023 02:32
kostmo
kostmo approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@kostmo kostmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some documentation and style nits.

src/Swarm/Util.hs Show resolved Hide resolved
src/Swarm/Game/Step.hs Outdated Show resolved Hide resolved
src/Swarm/Game/Step.hs Outdated Show resolved Hide resolved
src/Swarm/Game/Step.hs Outdated Show resolved Hide resolved
src/Swarm/Game/Step.hs Outdated Show resolved Hide resolved
src/Swarm/Game/Step.hs Outdated Show resolved Hide resolved
src/Swarm/Util.hs Outdated Show resolved Hide resolved
@byorgey byorgey added the merge me Trigger the merge process of the Pull request. label Apr 2, 2023
@mergify mergify bot merged commit e17d97c into main Apr 2, 2023
8 checks passed
@mergify mergify bot deleted the feature/requirements-logging branch April 2, 2023 20:43
@byorgey byorgey mentioned this pull request Apr 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostmo kostmo kostmo approved these changes

@xsebek xsebek Awaiting requested review from xsebek

Assignees
No one assigned
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display definition requirements
2 participants
@byorgey @kostmo