lights out #1273
Merged
lights out #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify bot
pushed a commit
that referenced
this pull request
May 20, 2023
# Summary This PR allows a recipe's effects to be applied within the same tick if `time: 0` is specified for the recipe. The previous behavior was that if the `time` of the recipe was zero, it would nonetheless behave the same as `time: 1`, and the entity updates would not be applied until the next tick. This new behavior is useful when "abusing" the `drill` command to emulate various other games via help from a system robot. # Motivation For the "Lights Out" game (#1273) I have implemented a system robot that `instant`-ly toggles the four adjacent lights and the center light when a center light is `drill`-ed by the player. The light entities are named `"off"` and `"on"`. I did some experiments to see if the system robot would react "fast enough" if the player drilled quickly in succession. # Experiments The 5x5 light grid is initially `"off"`. I moved the player robot to the center of the grid, facing `east`. From this position, I tried three command sequence variations both *before* and *after* this PR. The recipes for toggling lights specify `time: 0`. ## Before this PR ### 1. Drilling twice in succession drill down; drill left; This resulted in an error:  so only the first `drill` got applied:  This is because I believe the sequence of events was: | Tick / Robot | Action | | --- | --- | | **Tick 1:** Player | Execute the first `drill` command, queue entity modification | | **Tick 1:** System | No changes observed | | **Tick 2:** Player | Entity modification from first `drill` is applied. Execute second `drill` command, queue second entity modifications | | **Tick 2:** System | Observe modified entity, toggle the adjacent lights | | **Tick 3:** Player | Try to apply entity modification from second `drill` command. Throw an error because the system robot has toggled the drill's target entity to `on` whereas the `drill` was initially executed when it was still `off`. | ### 2. Instant for both drills instant $ (drill down; drill left) In this case, both of the player's `drill` commands were executed, but the system robot then failed to doubly-invert one of the cells:  This is due to some kind of race condition in the system robot's logic. However, it is irrelevant because the `instant` command shall not be available to the player. ### 3. Instant for first drill only, then second drill instant (drill down); drill left; This accomplished what approach number 1 was supposed to; both drill commands were applied and the two overlapping cells got properly inverted:  **Explanation:** In this case, the entire drilling operation (including applying all effects to entities on the ground) was completed within the player's first tick, so the system robot updated the lights appropriately on its turn. Then, in the next tick the player robot applied another drill command, and again the system robot appropriately did another inversion on the two overlapping middle cells. ## After this PR ### 1. Drilling twice in succession drill down; drill left; Now works as expected:  ### 2. and 3. Behaved identically to before the PR.
kostmo
force-pushed
the
scenario/lights-out
branch
2 times, most recently
from
d306d59
to
db1bd9c
Compare
kostmo
force-pushed
the
scenario/lights-out
branch
from
db1bd9c
to
e655faf
Compare
kostmo
force-pushed
the
scenario/lights-out
branch
from
e655faf
to
30985f2
Compare
byorgey
approved these changes
May 22, 2023
There was a problem hiding this comment.
Very nice! I was able to solve it manually. Tried coding up an automated solution and came up with the "chasing lights" idea but then wasn't sure what to do when there were lights left in the last row. Then I read the links in the solution and I learned a lot of interesting things about this puzzle. 😄
| case maybePending return $ flipSelfAndNeighbors state; | ||
| end; | ||
|
|
||
| def observe = \boardWidth. \boardHeight. |
There was a problem hiding this comment.
This function doesn't seem to use boardWidth and boardHeight at all?
| togglePending "on"; | ||
| togglePending "off"; | ||
| ); | ||
| observe boardWidth boardHeight; |
There was a problem hiding this comment.
Maybe insert a wait 1 here? As it is, I think it may do the instant call multiple times in one tick, until it uses up its step allotment. It's not a big deal but I think it would be cleaner/more efficient to wait 1 before the recursive call.
kostmo
force-pushed
the
scenario/lights-out
branch
from
304efde
to
517df26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://en.wikipedia.org/wiki/Lights_Out_(game)
The seed is not fixed; random valid games are generated and can be solved automatically via the provided solution.
One can use the solution strategy described here.