Recreate GameState from scratch when starting a scenario
#1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Restyled.io <commits@restyled.io>
|
@kostmo I always forget about the benchmarks. 🤦 Should be ready for you to take a look now! |
mergify bot
pushed a commit
that referenced
this pull request
Jun 5, 2023
I believe that since #1277 the progress has not been saved when exiting a scenario back to the menu. It is because `getNormalizedCurrentScenarioPath`, which is utilized by `saveScenarioInfoOnQuit`, was returning `Nothing`, in turn because `currentScenarioPath` was `Nothing`. This is because `scenarioToAppState` was clearing it immediately after being set inside `startGameWithSeed`. Foreshadowed by this comment: #1243 (review) .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All info that needs to be persistent (e.g. the set of standard/default entities and recipes) is now stored in the
RuntimeState. TheGameStaterecord is now recreated completely from scratch every time upon starting a new scenario, so custom entities and recipes from the previous scenario do not persist into the next.Fixes #516. Fixes #689.
Also a bunch of related refactoring/simplification relating to how we were initializing state for tests and benchmarks.
I also want to refactor the tests so we only load data from disk once, but I have split that out into a separate issue (#1279).