Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change binding on Hide REPL to M-, #1375

Merged
merged 4 commits into from Jul 19, 2023
Merged

Change binding on Hide REPL to M-, #1375

merged 4 commits into from Jul 19, 2023

Conversation

noahyor
Copy link
Member

@noahyor noahyor commented Jul 17, 2023

Fixes #1325.

@noahyor noahyor requested a review from byorgey July 17, 2023 15:36
@kostmo kostmo self-requested a review July 18, 2023 05:26
kostmo
kostmo requested changes Jul 18, 2023
View reviewed changes
src/Swarm/TUI/Controller.hs Outdated Show resolved Hide resolved
kostmo
kostmo reviewed Jul 18, 2023
View reviewed changes
src/Swarm/TUI/View.hs Outdated Show resolved Hide resolved
@kostmo
Copy link
Member

kostmo commented Jul 18, 2023

Thank you for pushing this one along!

noahyor and others added 2 commits July 18, 2023 20:17
@noahyor @kostmo
Fix Command Line Weirdness
ba1f33b 
Co-authored-by: Karl Ostmo <kostmo@gmail.com>
@noahyor @kostmo
Fix Command Line Weirdness Pt.2
b76e486 
Co-authored-by: Karl Ostmo <kostmo@gmail.com>
@noahyor noahyor requested review from kostmo and removed request for byorgey and kostmo July 19, 2023 00:19
@byorgey byorgey changed the title Change binding on Hide REPL to ^s Change binding on Hide REPL to M-, Jul 19, 2023
byorgey
byorgey approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the new M-, , seems to work.

@noahyor noahyor added the merge me Trigger the merge process of the Pull request. label Jul 19, 2023
@mergify mergify bot merged commit 56b0935 into main Jul 19, 2023
10 checks passed
@mergify mergify bot deleted the remap-minimize branch July 19, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostmo kostmo kostmo approved these changes

@byorgey byorgey byorgey approved these changes

Assignees
No one assigned
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remap dialog collapse key to ALT-comma
3 participants
@noahyor @kostmo @byorgey