Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include VS Code workspace settings in repo #1478

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Include VS Code workspace settings in repo #1478

merged 2 commits into from
Aug 28, 2023

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented Aug 28, 2023 •
edited

This saves a step in the development setup process.

Note that the settings file is included in the toplevel .gitignore, so any changes on top of this one will not result in a "dirty" repo.

@kostmo kostmo requested review from byorgey and xsebek August 28, 2023 18:27
@kostmo kostmo marked this pull request as ready for review August 28, 2023 18:27
@kostmo kostmo added the Z-Developer Experience This issue seeks to make life easier for developers writing Scenarios or other Swarm code. label Aug 28, 2023
xsebek
xsebek approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@xsebek xsebek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 I can imagine this will save me time once I delete it with git clean -fxd. 😄

@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label Aug 28, 2023
@mergify mergify bot merged commit f21a64f into main Aug 28, 2023
2 checks passed
@mergify mergify bot deleted the feature/vscode-settings branch August 28, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xsebek xsebek xsebek approved these changes

@byorgey byorgey Awaiting requested review from byorgey

Assignees
No one assigned
Labels
merge me Trigger the merge process of the Pull request. Z-Developer Experience This issue seeks to make life easier for developers writing Scenarios or other Swarm code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kostmo @xsebek