Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Achievement for pointless swapping #1588

Merged
merged 2 commits into from Oct 23, 2023
Merged

Achievement for pointless swapping #1588

merged 2 commits into from Oct 23, 2023

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented Oct 19, 2023 •
edited

Demo

scripts/play.sh -i creative --seed 0

Then:

turn right; move; turn right; move; t <- grab; move; swap t;

image

@kostmo kostmo requested review from byorgey and xsebek October 19, 2023 03:17
@restyled-io restyled-io bot mentioned this pull request Oct 19, 2023
Closed
@kostmo kostmo marked this pull request as ready for review October 19, 2023 03:20
@kostmo kostmo added the G-Achievements Inventing or improving Achievements label Oct 19, 2023
byorgey
byorgey approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I like the refactoring with mkReturn etc. and having doGrab return an Entity instead of a CESK.

@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label Oct 23, 2023
@mergify mergify bot merged commit d3889ef into main Oct 23, 2023
10 checks passed
@mergify mergify bot deleted the achievement/swap-same branch October 23, 2023 17:22
@kostmo kostmo added the CHANGELOG Once merged, this PR should be highlighted in the changelog for the next release. label Nov 1, 2023
@kostmo kostmo mentioned this pull request Nov 1, 2023
Merged
@kostmo kostmo mentioned this pull request Nov 10, 2023
Merged
mergify bot pushed a commit that referenced this pull request Nov 11, 2023
@kostmo
use mkReturn in more places (#1615)
1729917 
`mkReturn` originally introduced in #1588.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byorgey byorgey byorgey approved these changes

@xsebek xsebek Awaiting requested review from xsebek

Assignees
No one assigned
Labels
CHANGELOG Once merged, this PR should be highlighted in the changelog for the next release. G-Achievements Inventing or improving Achievements merge me Trigger the merge process of the Pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kostmo @byorgey