Merge new requirements context with existing when running from REPL #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #964. Unfortunately I don't know of any way to make a test for this. Part of the reason we went so long without noticing is that it only specifically affected the code path for running terms from the REPL, and tests can never run that code.
xsebek
approved these changes
Jan 5, 2023
|
@byorgey could you also change the line in integration tests? Right now it works, but if we ever touch requirements while loading scenarios (e.g. adding starting definitions) then they will be silently overwritten. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #964. Unfortunately I don't know of any way to make a test for this. Part of the reason we went so long without noticing is that it only specifically affected the code path for running terms from the REPL, and tests can never run that code.