refactor(ci): split test stage into build, lint, test

swarthy · May 26, 2024 · 692297d · 692297d
1 parent eeede99
commit 692297d
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/.github/workflows/branches.yml b/.github/workflows/branches.yml
@@ -34,4 +34,6 @@ jobs:
       - run: docker compose up -d redis1 redis2 redis3
       - run: docker compose run waiter
 
+      - run: yarn build
+      - run: yarn lint
       - run: yarn test-ci-with-coverage
diff --git a/.github/workflows/pull-requests.yml b/.github/workflows/pull-requests.yml
@@ -30,4 +30,6 @@ jobs:
       - run: docker compose up -d redis1 redis2 redis3
       - run: docker compose run waiter
 
+      - run: yarn build
+      - run: yarn lint
       - run: yarn test
diff --git a/package.json b/package.json
@@ -5,16 +5,16 @@
   "main": "lib/index.js",
   "module": "es/index.js",
   "scripts": {
-    "test": "eslint --ext .js,.ts . && mocha",
-    "test-ci-with-coverage": "eslint --ext .js,.ts . && nyc mocha && nyc report --reporter=text-lcov | coveralls",
+    "lint": "eslint --ext .js,.ts .",
+    "test": "mocha",
+    "test-ci-with-coverage": "nyc mocha && nyc report --reporter=text-lcov | coveralls",
     "coverage-html": "nyc mocha && nyc report --reporter=html",
     "converalls": "nyc mocha && nyc report --reporter=text-lcov | coveralls",
     "dev": "mocha -w",
-    "check-types": "tsc -b tsconfig.check-types.json",
     "build": "yarn build-commonjs",
     "build-commonjs": "rm -rf lib && yarn tsc -b tsconfig.build-commonjs.json",
     "build-es": "rm -rf es && yarn tsc -b tsconfig.build-es.json",
-    "preversion": "yarn test && yarn build"
+    "preversion": "yarn lint && yarn test && yarn build"
   },
   "repository": {
     "type": "git",