-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
swaygrab no longer exits #1350
Comments
I've tried to fix it myself, but it doesn't quite work yet: convert now exits with the following:
Here is my non-functional patch:
|
Ongy
pushed a commit
to Ongy/sway
that referenced
this issue
Sep 11, 2017
swaywm#1350 is fixed with this. The commit that change swaygrab to use fork instead of Popen tried to write to the read end of the pipe in the child branch and exec in the parent branch. This commit fixes both of those and closes the write fd after writing, so convert actually exits.
Can you test #1351 please? |
#1351 works, swaygrab seems to work fine now. |
Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When running the git version of Sway, swaygrab no longer works: it just waits there, doing nothing. I suspect fab5720 is to blame as it is the only commit since 0.14.0, but I have not formally bisected this.
The text was updated successfully, but these errors were encountered: