Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i3-incompatible hide_edge_borders interaction with stacked or tabbed containers #2912

Closed
thejan2009 opened this issue Oct 21, 2018 · 2 comments

Comments

@thejan2009
Copy link
Contributor

In sway, stacked or tabbed layout means that the view's titlebar will always be at least partially visible. In i3-wm the title can be hidden sometimes, for example when there's a single view and setting hide_edge_borders both. This makes the view essentially full-screen, minus the i3bar. But when a sibling view spawns, the tabbed or stacked titlebar becomes visible.

@RyanDwyer
Copy link
Member

Are you sure about this? When using hide_edge_borders both, we always show the title bar even for linear containers, and I believe that was copied from i3.

@thejan2009
Copy link
Contributor Author

Right, I seem to have missed another setting, default_border, configured to anything but normal. I have it set to pixel 1. The combination results in borders displaying only between tiled containers, and stacked or tiled containers with multiple direct children are the only ones that show their titlebars.

To reproduce, a minimal config:

default_border pixel 1
hide_edge_borders smart
workspace_layout tabbed

Then spawn a window, observe no borders or titlebars. Spawn another window, observe titlebar with two tabs. In sway, the titlebar is always present.

thejan2009 added a commit to thejan2009/sway that referenced this issue Feb 24, 2019
Behaves same as _both_ in i3wm with regards to tabbed/stacked containers. If
there is only one tabbed/stacked container child, title bar is hidden.

Related issues and merge requests: swaywm#3031, swaywm#3002, swaywm#2912, swaywm#2987.
thejan2009 added a commit to thejan2009/sway that referenced this issue Feb 24, 2019
Behaves same as _both_ in i3wm with regards to tabbed/stacked containers. If
there is only one tabbed/stacked container child, title bar is hidden.

Related issues and merge requests: swaywm#3031, swaywm#3002, swaywm#2912, swaywm#2987.
thejan2009 added a commit to thejan2009/sway that referenced this issue Feb 24, 2019
Behaves same as _both_ in i3wm with regards to tabbed/stacked containers. If
there is only one tabbed/stacked container child, title bar is hidden.

Related issues and merge requests: swaywm#3031, swaywm#3002, swaywm#2912, swaywm#2987.
thejan2009 added a commit to thejan2009/sway that referenced this issue Feb 24, 2019
Enables i3-compatible behavior regarding hiding the title bar on tabbed and
stacked containers with one child.

Related issues and merge requests: swaywm#3031, swaywm#3002, swaywm#2912, swaywm#2987.
thejan2009 added a commit to thejan2009/sway that referenced this issue Feb 24, 2019
Enables i3-compatible behavior regarding hiding the title bar on tabbed and
stacked containers with one child.

Related issues and merge requests: swaywm#3031, swaywm#3002, swaywm#2912, swaywm#2987.
RedSoxFan pushed a commit that referenced this issue Feb 24, 2019
Enables i3-compatible behavior regarding hiding the title bar on tabbed and
stacked containers with one child.

Related issues and merge requests: #3031, #3002, #2912, #2987.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants