Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore previous tabbed layout behavior #3031

Merged
merged 2 commits into from Oct 31, 2018
Merged

Restore previous tabbed layout behavior #3031

merged 2 commits into from Oct 31, 2018

Conversation

ghost
Copy link

@ghost ghost commented Oct 30, 2018

As discussed in issue #3002
Fixes #3002

@RyanDwyer
Copy link
Member

I just want to make it clear that what we currently have implemented matches exactly what i3 does, and by merging this we are intentionally diverging from i3's behaviour.

That said, I'm fine with this.

@progandy
Copy link
Contributor

progandy commented Oct 30, 2018 •
edited

It seems some people want this behaviour (#2912, #2987), maybe a configuration option is better like

hide_lone_tabs

Edit: Still, I am fine with removing it since the use case seems to mostly for full-screen views. Extending hide_edge_borders to hide titlebars if only one view exists in a workspace is better. (In a separate pull request).

@ddevault ddevault merged commit e21a233 into swaywm:master Oct 31, 2018
@ddevault
Copy link
Contributor

Follow-up ticket for the other behavior would be nice

@julientechdev julientechdev mentioned this pull request Jan 14, 2019
Closed
@RedSoxFan RedSoxFan mentioned this pull request Feb 12, 2019
Closed
thejan2009 added a commit to thejan2009/sway that referenced this pull request Feb 24, 2019
@thejan2009
introduce hide_edge_borders lone_tab
bc12841 
Behaves same as _both_ in i3wm with regards to tabbed/stacked containers. If
there is only one tabbed/stacked container child, title bar is hidden.

Related issues and merge requests: swaywm#3031, swaywm#3002, swaywm#2912, swaywm#2987.
thejan2009 added a commit to thejan2009/sway that referenced this pull request Feb 24, 2019
@thejan2009
introduce hide_edge_borders lone_tab
1f200d4 
Behaves same as _both_ in i3wm with regards to tabbed/stacked containers. If
there is only one tabbed/stacked container child, title bar is hidden.

Related issues and merge requests: swaywm#3031, swaywm#3002, swaywm#2912, swaywm#2987.
@thejan2009 thejan2009 mentioned this pull request Feb 24, 2019
Merged
thejan2009 added a commit to thejan2009/sway that referenced this pull request Feb 24, 2019
@thejan2009
introduce hide_edge_borders lone_tab
6116bc8 
Behaves same as _both_ in i3wm with regards to tabbed/stacked containers. If
there is only one tabbed/stacked container child, title bar is hidden.

Related issues and merge requests: swaywm#3031, swaywm#3002, swaywm#2912, swaywm#2987.
thejan2009 added a commit to thejan2009/sway that referenced this pull request Feb 24, 2019
@thejan2009
add --i3 flag to hide_edge_borders
7f2936f 
Enables i3-compatible behavior regarding hiding the title bar on tabbed and
stacked containers with one child.

Related issues and merge requests: swaywm#3031, swaywm#3002, swaywm#2912, swaywm#2987.
thejan2009 added a commit to thejan2009/sway that referenced this pull request Feb 24, 2019
@thejan2009
add --i3 flag to hide_edge_borders
b7a2a1b 
Enables i3-compatible behavior regarding hiding the title bar on tabbed and
stacked containers with one child.

Related issues and merge requests: swaywm#3031, swaywm#3002, swaywm#2912, swaywm#2987.
RedSoxFan pushed a commit that referenced this pull request Feb 24, 2019
@thejan2009 @RedSoxFan
add --i3 flag to hide_edge_borders
2510e3d 
Enables i3-compatible behavior regarding hiding the title bar on tabbed and
stacked containers with one child.

Related issues and merge requests: #3031, #3002, #2912, #2987.
@CodeJoule
Copy link

I just want to make it clear that what we currently have implemented matches exactly what i3 does, and by merging this we are intentionally diverging from i3's behaviour.

That said, I'm fine with this.

Why is this? It confused me for about an hour, since my i3 config wasn't working as it should with Sway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@RyanDwyer @progandy @ddevault @CodeJoule @emersion