Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sway tools such as swaybar and swaynag do not respond to touch input #5991

Closed
sicelo opened this issue Feb 2, 2021 · 0 comments · Fixed by #6003
Closed

sway tools such as swaybar and swaynag do not respond to touch input #5991

sicelo opened this issue Feb 2, 2021 · 0 comments · Fixed by #6003
Labels
bug Not working as intended input/touch swaybar swaynag

Comments

@sicelo
Copy link

sicelo commented Feb 2, 2021 •
edited

  • Sway Version:

    • 1.5-40bdd0ee (Jan 6 2021, branch 'master')

  • Debug Log:

  • Description:

    • swaynag and swaybar do not react to touch input on my phone, e.g. I cannot dismiss a swaynag prompt.

  • Additional info

    • ``swaymsg -t get_inputs` output for this touchscreen (it's a single-touch, resistive touch panel):
    Type: Touch
Identifier: 0:2005:TSC2005_touchscreen 
Product ID: 2005
Vendor ID: 0
Libinput Send Events: enabled
@sicelo sicelo added the bug Not working as intended label Feb 2, 2021
kennylevinsen added a commit to kennylevinsen/sway that referenced this issue Feb 7, 2021
@kennylevinsen
swaynag: Use position from wl_pointer.enter
cbfc37e 
Only wl_pointer.motion was used to update pointer position, which would
cause issues if the pointer was not moved prior to wl_pointer.button.

This also fixes touch input through wl_pointer emulation, which fires
wl_pointer.button immediately after wl_pointer.enter.

Closes: swaywm#5991
@kennylevinsen kennylevinsen mentioned this issue Feb 7, 2021
Merged
Xyene pushed a commit that referenced this issue Feb 8, 2021
@kennylevinsen @Xyene
swaynag: Use position from wl_pointer.enter
63420a2 
Only wl_pointer.motion was used to update pointer position, which would
cause issues if the pointer was not moved prior to wl_pointer.button.

This also fixes touch input through wl_pointer emulation, which fires
wl_pointer.button immediately after wl_pointer.enter.

Closes: #5991
neon64 pushed a commit to neon64/sway that referenced this issue Feb 11, 2021
@kennylevinsen @neon64
swaynag: Use position from wl_pointer.enter
5d7dc0a 
Only wl_pointer.motion was used to update pointer position, which would
cause issues if the pointer was not moved prior to wl_pointer.button.

This also fixes touch input through wl_pointer emulation, which fires
wl_pointer.button immediately after wl_pointer.enter.

Closes: swaywm#5991
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Not working as intended input/touch swaybar swaynag
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

swaynag: Use position from wl_pointer.enter kennylevinsen/sway
2 participants
@emersion @sicelo