Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swaynag: Use position from wl_pointer.enter #6003

Merged
merged 1 commit into from
Feb 8, 2021

Conversation

kennylevinsen
Copy link
Member

Only wl_pointer.motion was used to update pointer position, which would
cause issues if the pointer was not moved prior to wl_pointer.button.

This also fixes touch input through wl_pointer emulation, which fires
wl_pointer.button immediately after wl_pointer.enter.

Closes: #5991

Only wl_pointer.motion was used to update pointer position, which would
cause issues if the pointer was not moved prior to wl_pointer.button.

This also fixes touch input through wl_pointer emulation, which fires
wl_pointer.button immediately after wl_pointer.enter.

Closes: swaywm#5991
Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! This has got to be one of the most common oversights Wayland clients make... I've seen variations of it in five different projects by now :')

@Xyene Xyene merged commit 63420a2 into swaywm:master Feb 8, 2021
@kennylevinsen kennylevinsen deleted the swaynag_pointer branch February 8, 2021 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

sway tools such as swaybar and swaynag do not respond to touch input
2 participants