Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sway does not recognize 'Super' as a modifier key name #8084

Closed
Ferdi265 opened this issue Mar 23, 2024 · 2 comments
Closed

Sway does not recognize 'Super' as a modifier key name #8084

Ferdi265 opened this issue Mar 23, 2024 · 2 comments
Labels
enhancement New feature or incremental improvement

Comments

@Ferdi265
Copy link
Contributor

Description

Sway currently supports only the XKB modifier names and a few custom additions so that the familiar names "Ctrl" and "Alt" work as expected (as well as adding "Mod3" and "Mod5" that aren't defined as XKB_MOD_NAME_* macros).

What's missing is any human-readable name for the Logo (or Super) key, which is an issue that has confused many people starting out with sway that I know. Even the default sway config has to go out of its way to comment # Logo key. before set $mod Mod4 in order to not confuse potential first-time users.

Desired Feature

Allow using "Super", "Meta", or "Logo" as a modifier name for the logo key as well, instead of only "Mod4".

If that whole list is a little much, maybe decide on at least one human-readable name for the modifier key instead of just "Mod4".

Prior Art

  • Linux input-event-codes.h calls the logo key META
  • Gnome calls the logo key "Super"
  • KDE calls the logo key "Meta"
  • Hyprland calls the logo key "SUPER", "LOGO", "WIN", or "MOD4"
  • i3 calls the logo key "Mod4"

Prior Art for deviating from what i3 does

Sway also supports "Alt" as a modifier name, despite i3 not supporting that.
This was implemented along with the "Ctrl" alias (which i3 does support) in response to #153.

@Ferdi265 Ferdi265 added the enhancement New feature or incremental improvement label Mar 23, 2024
emersion pushed a commit that referenced this issue Apr 5, 2024
This PR implements alternative human-readable names for the logo key
(Mod4) as proposed in #8084.
@WhyNotHugo
Copy link
Contributor

Fixed in bc258a3

@Ferdi265 Ferdi265 closed this as completed May 1, 2024
@Ferdi265
Copy link
Contributor Author

Ferdi265 commented May 1, 2024

Fixed in bc258a3

right. I forgot the commit didn't have a "Closes" tag; Closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or incremental improvement
Development

No branches or pull requests

2 participants