-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
input: add Super as alternative for Mod4 #8085
Conversation
I'd be fine with adding a more user-friendly name, but would prefer not to add a whole bunch of aliases that mean the same thing. My preference would be to follow the libxkbcommon naming here. Also this needs a man page update as well. |
Right. So just "Logo", plus documentation updates IIUC. I expected this and I'm fine with any of these, I mostly made this PR so broad so all options are on the table. Will adjust accordingly. |
36b9fe3
to
7f2c3e2
Compare
updated to allow only "Logo" instead of "Super", "Meta", and "Logo". I haven't found any explanation of modifier names in the man pages except a few examples. Would you accept a separate PR adding such a section that explains all of the supported modifier names or would you like this to be done in this PR? Should we update examples in the man pages or config to use symbolic names where possible? (The branch name doesn't fit any more, but that's on me, and renaming a branch while keeping the PR attached doesn't work IIRC, so so be it.) |
ahh, sorry, I was confused by I'm leaving this choice to you. I'm fine with either of them, so please tell me which one you prefer. (also, changing this to Super for now, which seems to be the recommended choice for Mod4 according to here) |
7f2c3e2
to
0c60513
Compare
Modifier documentation is now in branch feature-modifier-docs. I added it to the documentation for I also noticed that AltGr is also missing a human readable alias, so I added that in feature-altgr-modifier. Not sure if the sway project wants/needs that as well, but it's there if needed. Let me know and I will make a PR. |
Is there a way we can just get the virtual modifier names from the keymap to alias their real modifiers? That would basically implement this then, right? |
You mean
Oh, sorry, I thought we had these documented already but it doesn't seem like it. Either is fine! |
0c60513
to
38b222e
Compare
I made a new PR documenting the existing modifiers (#8087) and rebased this one on top of that in addition to documenting the Super modifier here. |
Super, Meta, etc. are virtual modifier names. They're at least present in the (standard US) keymap I can extract from xwayland, along with their real modifier associations. So, IIUC, it is possible by manual inspection of the keymap to map those names uniquely to real modifiers (Mod1, Mod4). I don't see any xkbcommon api related to virtual modifiers though, so maybe I haven't fully understood their purpose. |
Yeah, I can see e.g. "Super" defined here:
But yeah, I don't see any way to extract this string from the XKB API. |
|
Seems like XKB (OG X Keyboard Extension) had something like this [1][2] [1] https://man.archlinux.org/man/XkbGetVirtualMods.3 |
38b222e
to
dde9296
Compare
rebased since #8087 was merged |
dde9296
to
be3b859
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thank you! |
This PR implements alternative human-readable names for the logo key (Mod4) as proposed in #8084.
Implemented in this PR are the names "Super",
"Meta", and "Logo".This is the first time the supported modifier names have been touched since #153, almost 9 years ago (besides moving the code around into different files and switching from wlc to wlroots).