Bar mode/hidden_state events #2751

Previously, if a change was sent to all bars, it would only actually change the first bar it encountered, due to return value handling

This adds an id property to the bar, which will be used to filter barconfig_update events

This adds barconfig_update to the list of subscribed events, as well as checking when the other events need to be subscribed to.

… enabled

This distinguishes the binding mode from the distinct config mode, as well as removing mode_pango_markup from the config struct where it should not be present.

The received json is handled outside of the case statement, which will allow better extensibility. This commit also introduces the variable bar_is_dirty, the return value signifying whether the bar requires rendering.

As well as adding the hidden_state property to the bar config struct, this commit handles barconfig_update events when the mode or hidden_state changes, and uses a new function determine_bar_visibility to hide or show the bar as required, using, respectively, destroy_layer_surface, which is also newly added, and add_layer_surface, which has been changed to allow dynamically adding the surface.

Since wayland does not currently allow swaybar to create global keybinds, this is handled within sway and sent to the bar using a custom event, so as not to pollute existing events, called bar_state_update.

Previously, when the bar was hidden, the height would be set to 0. This meant that if the bar was empty upon reshow, it would not render since the height was still 0, which made it seem there was a problem. Now, the height is not reset, but the width is, to indicate upon reshow that the layer surface needed reconfiguring.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bar mode/hidden_state events #2751

Bar mode/hidden_state events #2751

Commits on Oct 14, 2018