output: Really fix max render time #4772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennylevinsen
changed the title
YaLTeR
suggested changes
Nov 30, 2019
Repaint scheduling delays output render and frame done events from output frame events, and block idle frame events from being scheduled in between output frame done and output render in this period of time. If a surface is committed after its frame done event, but before output render, idle frame requests will be blocked, and the surface relies on the upcoming render to schedule a frame. If when the repaint timer expires, output render is deemed unnecessary, no frame will be scheduled. This can lead to surfaces never having their frame callbacks fire. To fix this, we store that a surface has requested a frame in surface_needs_frame. When the repaint expires, if no render is deemed necessary, we check this flag and schedule an idle frame. Fixes swaywm#4768
kennylevinsen
force-pushed
the
really-fix-max-render-time
branch
from
1d92fcf
to
ed75aa7
Compare
|
Feel free to give it a go.
|
|
Seems to be working pretty well in limited testing with output max_render_time of 3ms and view max_render_time of 2ms (Radeon Vega VII, Mesa 20-git). Any finer than that and glxgears which I've been using to test and my browser start dropping frames. Latency feels significantly improved. |
|
Yeah, looks like this is working well on my tests. |
YaLTeR
approved these changes
Dec 1, 2019
emersion
added a commit
to emersion/wlroots
that referenced
this pull request
Dec 1, 2019
This reverts commit cbb2781. In [1], we found issues with block_idle_frame and replaced it with frame_pending. block_idle_frame is now unused. [1]: swaywm/sway#4772
ddevault
pushed a commit
to swaywm/wlroots
that referenced
this pull request
Dec 1, 2019
This reverts commit cbb2781. In [1], we found issues with block_idle_frame and replaced it with frame_pending. block_idle_frame is now unused. [1]: swaywm/sway#4772
aiqs4
pushed a commit
to aiqs4/wlroots
that referenced
this pull request
Dec 19, 2019
This reverts commit cbb2781. In [1], we found issues with block_idle_frame and replaced it with frame_pending. block_idle_frame is now unused. [1]: swaywm/sway#4772
aiqs4
pushed a commit
to aiqs4/wlroots
that referenced
this pull request
Dec 19, 2019
This reverts commit cbb2781. In [1], we found issues with block_idle_frame and replaced it with frame_pending. block_idle_frame is now unused. [1]: swaywm/sway#4772
aiqs4
pushed a commit
to aiqs4/wlroots
that referenced
this pull request
Dec 19, 2019
This reverts commit cbb2781. In [1], we found issues with block_idle_frame and replaced it with frame_pending. block_idle_frame is now unused. [1]: swaywm/sway#4772
aiqs4
pushed a commit
to aiqs4/wlroots
that referenced
this pull request
Dec 19, 2019
This reverts commit cbb2781. In [1], we found issues with block_idle_frame and replaced it with frame_pending. block_idle_frame is now unused. [1]: swaywm/sway#4772
aiqs4
pushed a commit
to aiqs4/wlroots
that referenced
this pull request
Dec 19, 2019
This reverts commit cbb2781. In [1], we found issues with block_idle_frame and replaced it with frame_pending. block_idle_frame is now unused. [1]: swaywm/sway#4772
filips
pushed a commit
to filips/wlroots
that referenced
this pull request
Mar 15, 2020
This reverts commit cbb2781. In [1], we found issues with block_idle_frame and replaced it with frame_pending. block_idle_frame is now unused. [1]: swaywm/sway#4772
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix (#4766) was discovered to just treat a symptom rather than the cause, and did not account for proper use of per-view max_render_time.
This PR restores the original behavior of view max_render_time, and instead ensures that surface commits always result in a frame being scheduled, even if it occurred during our frame schedule block.