Remember if direct scanout fails #5010
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a view fails direct scanout, we remember if it fails so we don't bother trying again. This removes a lot of log spam of the atomic DRM test failing in this case.
|
The view could change its size or buffer format and it could work again. |
|
Needs update, my log is getting spammed. |
emersion
added a commit
to emersion/sway
that referenced
this pull request
Dec 9, 2020
This avoids some log spam. Eventually when we wire up the atomic test commit this will take care of the other log spam referenced below. References: swaywm#5010 References: swaywm/wlroots#2181 Closes: swaywm/wlroots#2532
Xyene
pushed a commit
that referenced
this pull request
Dec 20, 2020
This avoids some log spam. Eventually when we wire up the atomic test commit this will take care of the other log spam referenced below. References: #5010 References: swaywm/wlroots#2181 Closes: swaywm/wlroots#2532
|
This should help with the issue as well: swaywm/wlroots#2818 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a view fails direct scanout, we remember if it fails so we don't
bother trying again. This removes a lot of log spam of the atomic DRM
test failing in this case.