Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

"Unable to add DRM framebuffer" with mpv #2181

Closed
focus64 opened this issue May 10, 2020 · 8 comments
Closed

"Unable to add DRM framebuffer" with mpv #2181

focus64 opened this issue May 10, 2020 · 8 comments

Comments

@focus64
Copy link

focus64 commented May 10, 2020

mpv version: 0.32.0
wlroots version: 0.10.0.r124.gf72686c0-1 (up to f72686c)
sway version: sway version 1.4-726d187d (May 10 2020, branch 'master')

When mpv plays in fullscreen mode, lots of the following error messages are printed out.

[ERROR] [backend/drm/util.c:210] Unable to add DRM framebuffer: Invalid argument

mpv command:

mpv --no-config --gpu-api=vulkan --gpu-context=waylandvk <something to play>

sway-drm.log

Not sure if it is wlroots' problem or mpv's though.

@emersion
Copy link
Member

Does everything still work fine even though error messages are printed?

@focus64
Copy link
Author

focus64 commented May 10, 2020

I didn't test many other apps. But it seems mpv and sway still work fine, despite the error message.

@emersion
Copy link
Member

So this is just Sway trying to use direct scan-out and failing (falling back to regular composition). This is harmless, but the error messages could be improved.

swaywm/sway#5010 is an attempt at reducing the noise.

@escalade
Copy link

This happens with RetroArch and RPCS3 too, aren't they supposed to be able to use direct scan-out? Or maybe I'm confused as to what direct scan-out is :)

@emersion
Copy link
Member

Direct scan-out means that the display engine directly reads from the client's buffer, without the compositor needing to copy to an intermediate buffer. Whether direct scan-out is possible depends on the display engine capabilities and the buffer format/modifier used by the client.

@escalade
Copy link

I think this didn't happen before though. Also if I switch to OpenGL in RetroArch it doesn't occur.

@escalade
Copy link

escalade commented Jul 9, 2020

This is still an issue, my sway.log grows to 2MB after a couple minutes session in RPCS3 or RetroArch.

emersion added a commit to emersion/sway that referenced this issue Dec 9, 2020
This avoids some log spam.

Eventually when we wire up the atomic test commit this will take care of
the other log spam referenced below.

References: swaywm#5010
References: swaywm/wlroots#2181
Closes: swaywm/wlroots#2532
Xyene pushed a commit to swaywm/sway that referenced this issue Dec 20, 2020
This avoids some log spam.

Eventually when we wire up the atomic test commit this will take care of
the other log spam referenced below.

References: #5010
References: swaywm/wlroots#2181
Closes: swaywm/wlroots#2532
@emersion
Copy link
Member

The error messages should have been downgraded to DEBUG now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

3 participants