This repository has been archived by the owner on Aug 3, 2024. It is now read-only.
Fix xdg surface use-after-free by switching to NonNull #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we return an Option so we have to check it. This introduces overhead
that will be removed by switching to NonNull.
The one downside is one ugly, ugly thing:
Some(OptionalShellState(match self.state {
None => None,
Some(ref state) => Some(unsafe { state.clone() })
}))
This is a Some of an optional wrapper...so yeah it's really inefficient
and ugly in order to make it so that users can't clone shell states.
This is more efficient in terms of Option space compression, and it's safer. Though it's more verbose internally.
|
Switched everything over to use |
Timidger
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a use-after-free if
yad --entrywas ran in a compositor and then killed withSIGTERM(e.g. with ^C). This was because it was using the internal resource again when it upgraded the data.The first commit of this patch series is a naive fix. The rest of the commits are doing it better by changing how
Handlestores its data. It now stores aOption<D>. This was done because we needed a default forDbutDefaultisn't implemented for raw pointers (which mostDs were).However, since
Dwas always a pointer it could have been null this would have added overhead. To keep the cost down, and because it was a big change already, I also switched all the internal pointers over to NonNulls. This added some noise in the code, but makes it much more difficult to have these sort of errors hopefully.