Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

Move master version ahead of the last tag #2792

Closed
jbeich opened this issue Mar 17, 2021 · 6 comments
Closed

Move master version ahead of the last tag #2792

jbeich opened this issue Mar 17, 2021 · 6 comments

Comments

@jbeich
Copy link
Contributor

jbeich commented Mar 17, 2021

Consumers may want to support both latest release and master snapshot. To do so they can check WLR_VERSION_* but because wlroots only bumps minor version just before a tag is created it's not usable. So, some consumers choose to not support wlroots master until after the changes end up in a release that may end up being less stable due to not being tested in advance.

@emersion
Copy link
Member

Do people really want to support building with different wlroots versions? Looks like it would be some pretty annoying #ifdef soup…

@jbeich
Copy link
Contributor Author

jbeich commented Mar 18, 2021

For example, A project master branch uses dependency('wlroots', version: ['>=0.12.0', '<0.13.0']) and builds fine with wlroots 0.12.0 tag while B project master branch using the same statement fails because it wants wlroots master which hasn't bumped version yet.

@emersion
Copy link
Member

Right. Some projects use version numbers like 1.90.0 for the development version after 1.0.0 is released. I'm not a fan of abusing version numbers like this though…

@kennylevinsen
Copy link
Member

Yeah, let's not break version number continuity with hacks like that.

The cleanest method is probably just bumping the minor immediately after a tag, so master basically always represents an alpha/beta of a future release. It's the same amount of work as bumping before a release, although harder to remember to do. If we want to do a major release then two bumps will end up occurring between releases, but it shouldn't have any consequence. Patch releases when made on a maintenance branch from a release tag should be unaffected.

The "snapshot" version approach, just like the hack version number, is more of a chore as it requires first setting a real version number, tagging the release, then undoing the real version number again.

@emersion
Copy link
Member

The cleanest method is probably just bumping the minor immediately after a tag, so master basically always represents an alpha/beta of a future release.

That sounds like a good idea.

emersion added a commit that referenced this issue Apr 8, 2021
We now bump the version number right after releases, so that a Git
snapshot is not mistaken for a previous version.

References: #2792
@emersion
Copy link
Member

emersion commented Apr 8, 2021

Done in 1c10079. I've also updated the instructions on the wiki: https://github.com/swaywm/wlroots/wiki/Core-contributor-guide#releasing-a-new-version

@emersion emersion closed this as completed Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

3 participants