Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fixes #1689 RDP RemoteFX crash #1690
When using the rdp backend and connecting with
This commit guards against that and instead returns true, resulting in
When using the rdp backend and connecting with xfreerdp ... --rfx, wlroots crashes in backend/rdp/output.c while attempting to realloc(..., 0). This commit guards against that and instead returns true, resulting in no rfx message being sent. This prevents the crash and appears to work, but it's not obvious if this is correct from a specification perspective.
emersion left a comment
There's really no issue with that! The most important thing is to contribute at your own pace when you feel like it.
Thanks for the new version, this LGTM :)