Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1689 RDP RemoteFX crash #1690

Merged
merged 1 commit into from May 13, 2019

Conversation

@m01
Copy link
Contributor

m01 commented May 5, 2019

When using the rdp backend and connecting with xfreerdp ... --rfx, wlroots
crashes in backend/rdp/output.c while attempting to realloc(..., 0).

This commit guards against that and instead returns true, resulting in
no rfx message being sent. This prevents the crash and appears to work, but
it's not obvious if this is correct from a specification perspective.

backend/rdp/output.c Outdated Show resolved Hide resolved
@emersion

This comment has been minimized.

Copy link
Member

emersion commented May 12, 2019

Gentle ping :)

When using the rdp backend and connecting with xfreerdp ... --rfx, wlroots
crashes in backend/rdp/output.c while attempting to realloc(..., 0).

This commit guards against that and instead returns true, resulting in
no rfx message being sent. This prevents the crash and appears to work, but
it's not obvious if this is correct from a specification perspective.
@m01

This comment has been minimized.

Copy link
Contributor Author

m01 commented May 13, 2019

Thank you for the gentle nudge, and apologies for the delay in reacting, work & life have been busy. I updated the commit and force-pushed to my PR branch to keep the history clean.

Copy link
Member

emersion left a comment

apologies for the delay in reacting, work & life have been busy

There's really no issue with that! The most important thing is to contribute at your own pace when you feel like it.

Thanks for the new version, this LGTM :)

@emersion emersion merged commit a68c7c0 into swaywm:master May 13, 2019
3 checks passed
3 checks passed
builds.sr.ht: alpine.yml builds.sr.ht job completed successfully
Details
builds.sr.ht: archlinux.yml builds.sr.ht job completed successfully
Details
builds.sr.ht: freebsd.yml builds.sr.ht job completed successfully
Details
@m01

This comment has been minimized.

Copy link
Contributor Author

m01 commented May 13, 2019

PS: I tested it manually as before (just launched sway on my Desktop to ensure nothing egregious broke, and then ran it using WLR_BACKENDS=rdp and connected from my laptop using xfreerdp --rfx ...)

@m01

This comment has been minimized.

Copy link
Contributor Author

m01 commented May 13, 2019

Thank you for your guidance, and for giving me the opportunity to contribute!

@m01 m01 deleted the m01:bug/1689-rdp-rfx branch May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.