This repository has been archived by the owner on Nov 1, 2021. It is now read-only.
Introduce wlr_client_buffer #2043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
added a commit
to emersion/sway
that referenced
this pull request
Feb 28, 2020
Update for breaking changes in [1]. [1]: swaywm/wlroots#2043
emersion
force-pushed
the
client-buffer
branch
from
54fb6bd
to
5d574fc
Compare
emersion
added a commit
to emersion/glider
that referenced
this pull request
Feb 28, 2020
Update for [1]. Rename glider_wlr_buffer to glider_client_buffer, since the only use-case for importing a wlr_buffer is to get access to client buffers. [1]: swaywm/wlroots#2043
Split out the client/resource handling out of wlr_buffer by introducing wlr_client_buffer. Make wlr_buffer an interface so that compositors can create their own wlr_buffers (e.g. backed by GBM, like glider [1]). [1]: https://github.com/emersion/glider/blob/c66847dd1cf8ae5e68666ce7cb3be41427b38dc7/include/gbm_allocator.h#L7
emersion
force-pushed
the
client-buffer
branch
from
5d574fc
to
f1f45e0
Compare
|
Does this make #1910 obsolete? |
ddevault
approved these changes
Mar 6, 2020
|
Thanks! Nice work. |
emersion
added a commit
to emersion/sway
that referenced
this pull request
Mar 6, 2020
Update for breaking changes in [1]. [1]: swaywm/wlroots#2043
ddevault
pushed a commit
to swaywm/sway
that referenced
this pull request
Mar 6, 2020
Update for breaking changes in [1]. [1]: swaywm/wlroots#2043
emersion
added a commit
to emersion/glider
that referenced
this pull request
Mar 8, 2020
Update for [1]. Rename glider_wlr_buffer to glider_client_buffer, since the only use-case for importing a wlr_buffer is to get access to client buffers. [1]: swaywm/wlroots#2043
emersion
added a commit
to emersion/rootston
that referenced
this pull request
Mar 10, 2020
Update for [1]. [1]: swaywm/wlroots#2043
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out the client/resource handling out of wlr_buffer by introducing
wlr_client_buffer. Make wlr_buffer an interface so that compositors can
create their own wlr_buffers (e.g. backed by GBM, like glider 1).
Should we move
wlr_client_bufferto its own header file?This is a breaking change. Compositors that don't directly use
wlr_buffershouldn't need an update. For compositors which use it directly:wlr_bufferhas been renamed towlr_client_bufferwlr_buffer_{ref,unref,get_dmabuf}andwlr_output_attach_bufferstill take awlr_buffer, compositors need to use&wlr_client_buffer->basewlr_buffer_createandwlr_buffer_apply_damagehave been renamed towlr_client_buffer_createandwlr_client_buffer_apply_damagewlr_buffer_get_resource_sizehas been renamed towlr_resource_get_buffer_sizeSway PR: swaywm/sway#5049