backend/noop: listen to display destroy and destroy the backend #2583

ammen99 · 2020-12-29T14:39:41Z

Not sure if this is needed, but I guess it is a good idea, since most objects which are related to the display are destroyed when it is destroyed?

ifreund

I'm in favor of this, but this is a breaking change. I currently manually destroy the noop backend so if this was merged without changing river's code there would be a double free.

emersion

LGTM, thanks!

noop: listen to display destroy and destroy the backend

ee83f4c

ifreund approved these changes Dec 29, 2020

View reviewed changes

ammen99 added the breaking Breaking change in public API label Dec 29, 2020

emersion approved these changes Dec 31, 2020

View reviewed changes

emersion merged commit eb30cde into swaywm:master Dec 31, 2020

emersion changed the title ~~noop: listen to display destroy and destroy the backend~~ backend/noop: listen to display destroy and destroy the backend Mar 12, 2021

emersion mentioned this pull request Mar 12, 2021

wlroots 0.13.0 #2778

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

backend/noop: listen to display destroy and destroy the backend #2583

backend/noop: listen to display destroy and destroy the backend #2583

ammen99 commented Dec 29, 2020

ifreund left a comment •

edited

emersion left a comment

backend/noop: listen to display destroy and destroy the backend #2583

backend/noop: listen to display destroy and destroy the backend #2583

Conversation

ammen99 commented Dec 29, 2020

ifreund left a comment • edited

Choose a reason for hiding this comment

emersion left a comment

Choose a reason for hiding this comment

ifreund left a comment •

edited