This repository has been archived by the owner on Nov 1, 2021. It is now read-only.
xdg shell: add wlr_xdg_surface_for_each_popup_surface() #2609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, but this is about Use |
|
I've changed this commit to introduce a new function suitable for rendering instead of modifying the existing one. The API of the existing function is cleaned up in #2610. |
ifreund
changed the title
emersion
reviewed
Jan 7, 2021
When rendering, it is necessary to iterate the subsurfaces as well, so add a function that makes this easy.
emersion
approved these changes
Jan 8, 2021
emersion
added a commit
to emersion/sway
that referenced
this pull request
Jan 8, 2021
Instead of calling wlr_xdg_surface_for_each_popup and then wlr_surface_for_each_surface, use the new for_each_popup_surface helper introduced in [1] that does it in one go. [1]: swaywm/wlroots#2609
|
emersion
added a commit
to swaywm/sway
that referenced
this pull request
Jan 12, 2021
Instead of calling wlr_xdg_surface_for_each_popup and then wlr_surface_for_each_surface, use the new for_each_popup_surface helper introduced in [1] that does it in one go. [1]: swaywm/wlroots#2609
GorrillaRibs
pushed a commit
to GorrillaRibs/sway-borders
that referenced
this pull request
Jan 17, 2021
Instead of calling wlr_xdg_surface_for_each_popup and then wlr_surface_for_each_surface, use the new for_each_popup_surface helper introduced in [1] that does it in one go. [1]: swaywm/wlroots#2609
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Omitting these is a bug. Firefox for example only renders stuff tothe subsurfaces of its popups for whatever reason.
When rendering, it is necessary to iterate the subsurfaces as well,
so add a function that makes this easy.