This repository has been archived by the owner on Nov 1, 2021. It is now read-only.
xdg shell: remove wlr_xdg_surface_for_each_popup() #2610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should consider simply removing this function instead if #2609 is accepted. I don't know of any use case for iterating popups in a compositor aside from rendering. |
|
I agree. We can always re-introduce the function if a compositor finds a use-case. |
ifreund
force-pushed
the
xdg-pop-iter-cleanup
branch
from
99e2400
to
9b06bff
Compare
ifreund
changed the title
|
Sounds good to me, I changed the commit to remove this function instead. |
emersion
approved these changes
Jan 8, 2021
|
(Needs a rebase.) Sway pull request: swaywm/sway#5937 |
ifreund
force-pushed
the
xdg-pop-iter-cleanup
branch
from
9b06bff
to
fb65cf7
Compare
This function is inferior to wlr_xdg_surface_for_each_popup_surface() for rendering as it does not iterate over subsurfaces. Furthermore, no compositor is known to use this to iterate popups for any purpose other than rendering. Therefore remove the function, which may of course be reintroduced at a later date if a use-case is found.
ifreund
force-pushed
the
xdg-pop-iter-cleanup
branch
from
fb65cf7
to
536ab5d
Compare
|
Thanks! |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is not well suited to rendering as it does not iterateover subsurfaces. Therefore, it makes little sense to use the standard
surface iterator function. Introduce an new xdg-popup iterator function
and use that instead.
This function is inferior to wlr_xdg_surface_for_each_popup_surface()
for rendering as it does not iterate over subsurfaces. Furthermore,
no compositor known to use this to iterate popups for any purpose other
than rendering. Therefore remove the function which may of course be
reintroduced at a later date if a use-case is found.
Breaking change:
wlr_xdg_surface_for_each_popuphas been removed, usewlr_xdg_surface_for_each_popup_surfaceinstead.