This repository has been archived by the owner on Nov 1, 2021. It is now read-only.
layer-shell: replace close() with destroy() #3108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ideally we should make the layer-surface inert when the compositor decides to close it… |
ifreund
force-pushed
the
layer-surface-ignore-closed
branch
from
adf3020
to
7194d0c
Compare
Yep, that's cleaner. Done. |
ifreund
force-pushed
the
layer-surface-ignore-closed
branch
from
7194d0c
to
135a1f4
Compare
ifreund
changed the title
ifreund
changed the title
|
Changed this to actually destroy the layer_surface in close() in keeping with the section on inert resources in CONTRIBUTING.md. This is now a breaking change and should be marked as such. |
emersion
reviewed
Aug 13, 2021
ifreund
force-pushed
the
layer-surface-ignore-closed
branch
from
135a1f4
to
43e013c
Compare
ifreund
changed the title
|
@emersion good point, changing the function name will also make it easier for compositors to audit call sites when they update. |
The protocol specifies that all requests (aside from destroy) are ignored after the compositor sends the closed event. Therefore, destroying the wlroots object and rendering the resource inert when sending the closed event keeps things simpler for wlroots and compositors.
ifreund
force-pushed
the
layer-surface-ignore-closed
branch
from
43e013c
to
41ab4b2
Compare
|
Thanks! |
Open
emersion
added a commit
to swaywm/sway
that referenced
this pull request
Aug 14, 2021
Update for the wlroots breaking change in [1]. [1]: swaywm/wlroots#3108
johanmalm
added a commit
to labwc/labwc
that referenced
this pull request
Aug 16, 2021
Update for the wlroots breaking change in swaywm/wlroots#3108
telent
added a commit
to telent/labwc
that referenced
this pull request
Aug 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The protocol specifies that all requests (aside from destroy) are
ignored after the compositor sends the closed event. Therefore,
destroying the wlroots object and rendering the resource inert
when sending the closed event keeps things simpler for wlroots and
compositors.