Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

output: add presented flag to presentation event #3245

Merged
merged 3 commits into from
Oct 15, 2021
Merged

output: add presented flag to presentation event #3245

merged 3 commits into from
Oct 15, 2021

Conversation

vyivel
Copy link

@vyivel vyivel commented Oct 8, 2021 •
edited

See individual commits.

This is breaking change for custom backend users: wlr_output_send_present() doesn't accept NULL events anymore, and events must have their newly introduced presented flag set.

@vyivel vyivel mentioned this pull request Oct 9, 2021
Merged
@vyivel
Copy link
Author

vyivel commented Oct 13, 2021

Alternatively, wlr_output_send_discard() could be introduced instead of changing wlr_output_send_present().

@emersion emersion added breaking Breaking change in public API and removed breaking Breaking change in public API labels Oct 15, 2021
emersion
emersion approved these changes Oct 15, 2021
View reviewed changes
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I was wondering whether this was a breaking change, but it doesn't seem like it. The present events are fired the same way as before, this PR just introduces a new field.

@emersion emersion merged commit 2edf468 into swaywm:master Oct 15, 2021
@vyivel vyivel deleted the output-discard branch October 15, 2021 07:56
@vyivel vyivel mentioned this pull request Oct 15, 2021
Open
@emersion emersion added the breaking Breaking change in public API label Oct 15, 2021
emersion added a commit to swaywm/sway that referenced this pull request Oct 15, 2021
@emersion
Handle present events with NULL timespec field
0c210a5 
See [1].

[1]: swaywm/wlroots#3245
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@emersion emersion emersion approved these changes

Assignees
No one assigned
Labels
breaking Breaking change in public API
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vyivel @emersion