Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

Add wlr_surface_point_accepts_input #787

Merged
merged 1 commit into from
Mar 31, 2018
Merged

Add wlr_surface_point_accepts_input #787

merged 1 commit into from
Mar 31, 2018

Conversation

ddevault
Copy link
Contributor

@ddevault ddevault requested a review from emersion March 31, 2018 02:20
@emersion
Copy link
Member

Can you move wlr_box_contains_point(&box, view_sx, view_sy) inside?

@ddevault
Copy link
Contributor Author

Can you move wlr_box_contains_point(&box, view_sx, view_sy) inside?

No, that's in output coords

@emersion
Copy link
Member

Need to use this function in layer_surface_at too.

No, that's in output coords

I mean, the only thing this function does is checking if the output-local surface box contains the output-local point. You can just add a sx => 0 && sx <= surface->current->width (ditto for sy) in the new function and remove these calls to wlr_box_contains_point (and the code building that box).

@ddevault
Copy link
Contributor Author

Good call.

@emersion emersion merged commit f133170 into master Mar 31, 2018
@emersion emersion deleted the input-point branch March 31, 2018 03:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants