Skip to content

Commit

Permalink
feat(html/minifier): Minify js (#4999)
Browse files Browse the repository at this point in the history
  • Loading branch information
@alexander-akait
alexander-akait committed Jun 21, 2022
1 parent 0f825eb commit 28bc735
Show file tree
Hide file tree
Showing 28 changed files with 607 additions and 139 deletions.
6 changes: 6 additions & 0 deletions Cargo.lock
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 3 additions & 4 deletions crates/swc_css_parser/src/parser/base.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,12 @@ where
// If the top-level flag is set, do nothing.
if ctx.is_top_level {
bump!(self);

continue;
}

// Otherwise, reconsume the current input token. Consume a qualified rule. If
// anything is returned, append it to the list of rules.
rules.push(Rule::QualifiedRule(self.parse()?));
else {
rules.push(Rule::QualifiedRule(self.parse()?));
}
}
// <at-keyword-token>
// Reconsume the current input token. Consume an at-rule, and append the returned
Expand Down
8 changes: 7 additions & 1 deletion crates/swc_html_minifier/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,14 @@ swc_common = { version = "0.18.0", path = "../swc_common" }
swc_css_codegen = { version = "0.103.0", path = "../swc_css_codegen" }
swc_css_parser = { version = "0.102.0", path = "../swc_css_parser" }
swc_css_minifier = { version = "0.68.0", path = "../swc_css_minifier" }
swc_ecma_ast = { version = "0.79.0", path = "../swc_ecma_ast" }
swc_ecma_codegen = { version = "0.109.1", path = "../swc_ecma_codegen" }
swc_ecma_parser = { version = "0.105.5", path = "../swc_ecma_parser" }
swc_ecma_transforms_base = { version = "0.89.5", path = "../swc_ecma_transforms_base" }
swc_ecma_minifier = { version = "0.122.0", path = "../swc_ecma_minifier" }
swc_ecma_visit = { version = "0.65.0", path = "../swc_ecma_visit" }
swc_html_ast = { version = "0.10.0", path = "../swc_html_ast" }
swc_html_codegen = { version = "0.14.0", path = "../swc_html_codegen" }
swc_html_codegen = { version = "0.14.1", path = "../swc_html_codegen" }
swc_html_visit = { version = "0.10.0", path = "../swc_html_visit" }
swc_html_parser = { version = "0.13.0", path = "../swc_html_parser" }

Expand Down

1 comment on commit 28bc735

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 28bc735 Previous: 125549b Ratio
es/full/minify/libraries/antd 1685427049 ns/iter (± 37565970) 1704654690 ns/iter (± 40849438) 0.99
es/full/minify/libraries/d3 413182541 ns/iter (± 17793707) 428188470 ns/iter (± 34487944) 0.96
es/full/minify/libraries/echarts 1647465754 ns/iter (± 31833290) 1652355661 ns/iter (± 57978736) 1.00
es/full/minify/libraries/jquery 101333050 ns/iter (± 7657148) 104978970 ns/iter (± 11077339) 0.97
es/full/minify/libraries/lodash 122507281 ns/iter (± 3084623) 135844982 ns/iter (± 15879698) 0.90
es/full/minify/libraries/moment 51834807 ns/iter (± 653804) 56669939 ns/iter (± 6886952) 0.91
es/full/minify/libraries/react 17223150 ns/iter (± 208381) 17809170 ns/iter (± 888629) 0.97
es/full/minify/libraries/terser 592027650 ns/iter (± 10238504) 616908302 ns/iter (± 18093616) 0.96
es/full/minify/libraries/three 543147583 ns/iter (± 10283654) 552321048 ns/iter (± 39261032) 0.98
es/full/minify/libraries/typescript 3513344098 ns/iter (± 79051020) 3517234572 ns/iter (± 115614210) 1.00
es/full/minify/libraries/victory 711845757 ns/iter (± 4378559) 730804468 ns/iter (± 34181081) 0.97
es/full/minify/libraries/vue 129785141 ns/iter (± 1490715) 146488155 ns/iter (± 12192236) 0.89
es/full/codegen/es3 32450 ns/iter (± 1089) 32443 ns/iter (± 1197) 1.00
es/full/codegen/es5 32486 ns/iter (± 1435) 32294 ns/iter (± 2073) 1.01
es/full/codegen/es2015 32365 ns/iter (± 1072) 32504 ns/iter (± 1595) 1.00
es/full/codegen/es2016 32369 ns/iter (± 738) 32385 ns/iter (± 1843) 1.00
es/full/codegen/es2017 32618 ns/iter (± 481) 32365 ns/iter (± 2122) 1.01
es/full/codegen/es2018 32544 ns/iter (± 739) 32333 ns/iter (± 2463) 1.01
es/full/codegen/es2019 33263 ns/iter (± 1262) 32325 ns/iter (± 1650) 1.03
es/full/codegen/es2020 32616 ns/iter (± 1064) 32241 ns/iter (± 387) 1.01
es/full/all/es3 187728035 ns/iter (± 7024995) 204313333 ns/iter (± 16169477) 0.92
es/full/all/es5 173111609 ns/iter (± 6838584) 189973083 ns/iter (± 16133226) 0.91
es/full/all/es2015 145116261 ns/iter (± 4138379) 158752543 ns/iter (± 14999576) 0.91
es/full/all/es2016 144115644 ns/iter (± 4763444) 156427165 ns/iter (± 11234911) 0.92
es/full/all/es2017 142952297 ns/iter (± 6616320) 152368296 ns/iter (± 9989403) 0.94
es/full/all/es2018 136882588 ns/iter (± 3318326) 152673895 ns/iter (± 10653145) 0.90
es/full/all/es2019 135838256 ns/iter (± 2817567) 151826185 ns/iter (± 10191093) 0.89
es/full/all/es2020 130630592 ns/iter (± 2570185) 150275107 ns/iter (± 11548777) 0.87
es/full/parser 706387 ns/iter (± 16733) 730571 ns/iter (± 66899) 0.97
es/full/base/fixer 28710 ns/iter (± 462) 29763 ns/iter (± 2341) 0.96
es/full/base/resolver_and_hygiene 85299 ns/iter (± 2442) 91403 ns/iter (± 27708) 0.93
serialization of ast node 218 ns/iter (± 4) 210 ns/iter (± 18) 1.04
serialization of serde 226 ns/iter (± 4) 218 ns/iter (± 10) 1.04

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.