Skip to content

Commit

Permalink
fix(es/preset-env): Don't log Yield to the console (#7548)
Browse files Browse the repository at this point in the history 
**Description:**

When a `yield` token is encountered by the parser, the word "Yield" is unnecessarily logged to the console. This PR removes the extra logging.
  • Loading branch information
Curtis Wilson committed Jun 20, 2023
1 parent 8f1c8ea commit 8cfc4f9
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion crates/swc_ecma_preset_env/src/corejs2/mod.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,6 @@ impl Visit for UsageVisitor {
/// - `yield*`
fn visit_yield_expr(&mut self, e: &YieldExpr) {
e.visit_children_with(self);
println!("Yield");

if e.delegate {
self.add(&["web.dom.iterable"])
Expand Down

1 comment on commit 8cfc4f9

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 8cfc4f9 Previous: 1d84e95 Ratio
es/full/bugs-1 302056 ns/iter (± 3634) 356857 ns/iter (± 3432) 0.85
es/full/minify/libraries/antd 1423622831 ns/iter (± 6486602) 1837113840 ns/iter (± 27369611) 0.77
es/full/minify/libraries/d3 314769745 ns/iter (± 3403182) 369359651 ns/iter (± 7568330) 0.85
es/full/minify/libraries/echarts 1158980118 ns/iter (± 4502476) 1428024744 ns/iter (± 17208784) 0.81
es/full/minify/libraries/jquery 94388193 ns/iter (± 210040) 108924772 ns/iter (± 1020225) 0.87
es/full/minify/libraries/lodash 111989292 ns/iter (± 255926) 131894460 ns/iter (± 1589919) 0.85
es/full/minify/libraries/moment 55368530 ns/iter (± 91391) 63784925 ns/iter (± 692088) 0.87
es/full/minify/libraries/react 19984053 ns/iter (± 32882) 22790601 ns/iter (± 162608) 0.88
es/full/minify/libraries/terser 242492183 ns/iter (± 706204) 290696643 ns/iter (± 3177421) 0.83
es/full/minify/libraries/three 426071848 ns/iter (± 2234266) 520390420 ns/iter (± 10863362) 0.82
es/full/minify/libraries/typescript 2948448495 ns/iter (± 4441226) 3535194998 ns/iter (± 18570781) 0.83
es/full/minify/libraries/victory 618772276 ns/iter (± 3692283) 765750333 ns/iter (± 11984182) 0.81
es/full/minify/libraries/vue 136151594 ns/iter (± 196664) 157158877 ns/iter (± 1407612) 0.87
es/full/codegen/es3 35693 ns/iter (± 127) 41128 ns/iter (± 164) 0.87
es/full/codegen/es5 35684 ns/iter (± 79) 40871 ns/iter (± 150) 0.87
es/full/codegen/es2015 35648 ns/iter (± 126) 40798 ns/iter (± 177) 0.87
es/full/codegen/es2016 35633 ns/iter (± 132) 40839 ns/iter (± 353) 0.87
es/full/codegen/es2017 35652 ns/iter (± 80) 40802 ns/iter (± 373) 0.87
es/full/codegen/es2018 35597 ns/iter (± 88) 40643 ns/iter (± 176) 0.88
es/full/codegen/es2019 35698 ns/iter (± 54) 40739 ns/iter (± 169) 0.88
es/full/codegen/es2020 35657 ns/iter (± 92) 40805 ns/iter (± 252) 0.87
es/full/all/es3 179505721 ns/iter (± 643994) 207068009 ns/iter (± 3206526) 0.87
es/full/all/es5 169736867 ns/iter (± 1024064) 199034013 ns/iter (± 2221916) 0.85
es/full/all/es2015 127396222 ns/iter (± 909103) 156041621 ns/iter (± 2281307) 0.82
es/full/all/es2016 126080764 ns/iter (± 557792) 155908287 ns/iter (± 2257970) 0.81
es/full/all/es2017 125112330 ns/iter (± 393848) 153099241 ns/iter (± 2089028) 0.82
es/full/all/es2018 123828533 ns/iter (± 894987) 153228172 ns/iter (± 2803311) 0.81
es/full/all/es2019 122984570 ns/iter (± 1065578) 153204241 ns/iter (± 1569552) 0.80
es/full/all/es2020 119328640 ns/iter (± 368508) 148584363 ns/iter (± 3010187) 0.80
es/full/parser 516688 ns/iter (± 5781) 602750 ns/iter (± 10851) 0.86
es/full/base/fixer 19217 ns/iter (± 58) 24484 ns/iter (± 200) 0.78
es/full/base/resolver_and_hygiene 91599 ns/iter (± 86) 105033 ns/iter (± 924) 0.87
serialization of serde 297 ns/iter (± 0) 253 ns/iter (± 1) 1.17
css/minify/libraries/bootstrap 30923340 ns/iter (± 38734) 35517362 ns/iter (± 218264) 0.87
css/visitor/compare/clone 2128056 ns/iter (± 10482) 2323833 ns/iter (± 9263) 0.92
css/visitor/compare/visit_mut_span 2268017 ns/iter (± 13463) 2525709 ns/iter (± 16097) 0.90
css/visitor/compare/visit_mut_span_panic 2322966 ns/iter (± 11798) 2568282 ns/iter (± 10665) 0.90
css/visitor/compare/fold_span 3037092 ns/iter (± 10485) 3292790 ns/iter (± 20928) 0.92
css/visitor/compare/fold_span_panic 3224964 ns/iter (± 12413) 3488853 ns/iter (± 17749) 0.92
css/lexer/bootstrap_5_1_3 4860484 ns/iter (± 4066) 5551428 ns/iter (± 35729) 0.88
css/lexer/foundation_6_7_4 4086529 ns/iter (± 1547) 4661031 ns/iter (± 15478) 0.88
css/lexer/tailwind_3_1_1 778654 ns/iter (± 805) 890071 ns/iter (± 5755) 0.87
css/parser/bootstrap_5_1_3 20525137 ns/iter (± 39147) 23470279 ns/iter (± 187129) 0.87
css/parser/foundation_6_7_4 16564948 ns/iter (± 39881) 18834595 ns/iter (± 66544) 0.88
css/parser/tailwind_3_1_1 3196113 ns/iter (± 3478) 3671677 ns/iter (± 25474) 0.87
es/codegen/colors 729789 ns/iter (± 396418) 743879 ns/iter (± 405698) 0.98
es/codegen/large 2999439 ns/iter (± 1579531) 2967048 ns/iter (± 1562906) 1.01
es/codegen/with-parser/colors 48721 ns/iter (± 185) 57878 ns/iter (± 525) 0.84
es/codegen/with-parser/large 518163 ns/iter (± 978) 573555 ns/iter (± 3374) 0.90
es/minify/libraries/antd 1266263318 ns/iter (± 13840390) 1620275868 ns/iter (± 28167550) 0.78
es/minify/libraries/d3 278521797 ns/iter (± 491243) 320919929 ns/iter (± 3936325) 0.87
es/minify/libraries/echarts 1010910301 ns/iter (± 3760885) 1224595595 ns/iter (± 11640190) 0.83
es/minify/libraries/jquery 83091022 ns/iter (± 64347) 96200702 ns/iter (± 984628) 0.86
es/minify/libraries/lodash 102978599 ns/iter (± 206043) 119453394 ns/iter (± 829681) 0.86
es/minify/libraries/moment 49190103 ns/iter (± 81983) 56021991 ns/iter (± 408472) 0.88
es/minify/libraries/react 17974479 ns/iter (± 27176) 20341555 ns/iter (± 108463) 0.88
es/minify/libraries/terser 209376157 ns/iter (± 745300) 245807711 ns/iter (± 2150325) 0.85
es/minify/libraries/three 361917698 ns/iter (± 865445) 431232939 ns/iter (± 5584589) 0.84
es/minify/libraries/typescript 2534906498 ns/iter (± 8639318) 3056964705 ns/iter (± 18821035) 0.83
es/minify/libraries/victory 533885518 ns/iter (± 1752170) 646645912 ns/iter (± 18675092) 0.83
es/minify/libraries/vue 122699511 ns/iter (± 183145) 141753960 ns/iter (± 944021) 0.87
es/visitor/compare/clone 2086804 ns/iter (± 7291) 2391524 ns/iter (± 10326) 0.87
es/visitor/compare/visit_mut_span 2419087 ns/iter (± 4303) 2774348 ns/iter (± 22154) 0.87
es/visitor/compare/visit_mut_span_panic 2457811 ns/iter (± 3895) 2815073 ns/iter (± 14987) 0.87
es/visitor/compare/fold_span 3505890 ns/iter (± 10409) 3855159 ns/iter (± 15486) 0.91
es/visitor/compare/fold_span_panic 3653054 ns/iter (± 5851) 4005642 ns/iter (± 18328) 0.91
es/lexer/colors 13125 ns/iter (± 17) 14834 ns/iter (± 106) 0.88
es/lexer/angular 6225975 ns/iter (± 5424) 7069796 ns/iter (± 35138) 0.88
es/lexer/backbone 817278 ns/iter (± 1386) 858574 ns/iter (± 3831) 0.95
es/lexer/jquery 4630118 ns/iter (± 7382) 4825378 ns/iter (± 15355) 0.96
es/lexer/jquery mobile 7076442 ns/iter (± 8396) 7447997 ns/iter (± 26186) 0.95
es/lexer/mootools 3627073 ns/iter (± 16499) 3757861 ns/iter (± 30259) 0.97
es/lexer/underscore 676446 ns/iter (± 1404) 709292 ns/iter (± 2970) 0.95
es/lexer/three 21559187 ns/iter (± 27891) 22454613 ns/iter (± 119531) 0.96
es/lexer/yui 4106844 ns/iter (± 6645) 4295489 ns/iter (± 22243) 0.96
es/parser/colors 29115 ns/iter (± 27) 32838 ns/iter (± 286) 0.89
es/parser/angular 14538446 ns/iter (± 53014) 16429296 ns/iter (± 94761) 0.88
es/parser/backbone 2162470 ns/iter (± 8778) 2412627 ns/iter (± 11737) 0.90
es/parser/jquery 11719587 ns/iter (± 44772) 13012150 ns/iter (± 106851) 0.90
es/parser/jquery mobile 17938316 ns/iter (± 31855) 20341260 ns/iter (± 392679) 0.88
es/parser/mootools 8991187 ns/iter (± 15405) 9939745 ns/iter (± 60140) 0.90
es/parser/underscore 1873596 ns/iter (± 8720) 2076810 ns/iter (± 11352) 0.90
es/parser/three 49686052 ns/iter (± 138464) 59986076 ns/iter (± 961466) 0.83
es/parser/yui 9126879 ns/iter (± 168207) 10147313 ns/iter (± 66920) 0.90
es/preset-env/usage/builtin_type 148620 ns/iter (± 31601) 153718 ns/iter (± 34489) 0.97
es/preset-env/usage/property 20530 ns/iter (± 114) 28626 ns/iter (± 174) 0.72
es/resolver/typescript 93891804 ns/iter (± 875126) 127330260 ns/iter (± 3018613) 0.74
es/fixer/typescript 65876223 ns/iter (± 323182) 85642555 ns/iter (± 889456) 0.77
es/hygiene/typescript 143240358 ns/iter (± 1174451) 200386775 ns/iter (± 1631017) 0.71
es/resolver_with_hygiene/typescript 299291278 ns/iter (± 1301862) 406926444 ns/iter (± 5757775) 0.74
es/visitor/base-perf/module_clone 62750 ns/iter (± 361) 85819 ns/iter (± 335) 0.73
es/visitor/base-perf/fold_empty 65469 ns/iter (± 306) 94226 ns/iter (± 801) 0.69
es/visitor/base-perf/fold_noop_impl_all 65880 ns/iter (± 191) 94786 ns/iter (± 634) 0.70
es/visitor/base-perf/fold_noop_impl_vec 66411 ns/iter (± 227) 95255 ns/iter (± 987) 0.70
es/visitor/base-perf/boxing_boxed_clone 57 ns/iter (± 0) 60 ns/iter (± 0) 0.95
es/visitor/base-perf/boxing_unboxed_clone 40 ns/iter (± 0) 45 ns/iter (± 0) 0.89
es/visitor/base-perf/boxing_boxed 115 ns/iter (± 0) 116 ns/iter (± 0) 0.99
es/visitor/base-perf/boxing_unboxed 81 ns/iter (± 0) 82 ns/iter (± 0) 0.99
es/visitor/base-perf/visit_empty 0 ns/iter (± 0)
es/visitor/base-perf/visit_contains_this 2612 ns/iter (± 9) 3425 ns/iter (± 86) 0.76
es/base/parallel/resolver/typescript 4405453816 ns/iter (± 209995813) 7589534208 ns/iter (± 588349400) 0.58
es/base/parallel/hygiene/typescript 1579935501 ns/iter (± 12104030) 2402401567 ns/iter (± 20420676) 0.66
misc/visitors/time-complexity/time 5 106 ns/iter (± 0) 104 ns/iter (± 0) 1.02
misc/visitors/time-complexity/time 10 279 ns/iter (± 0) 351 ns/iter (± 0) 0.79
misc/visitors/time-complexity/time 15 600 ns/iter (± 41) 679 ns/iter (± 10) 0.88
misc/visitors/time-complexity/time 20 949 ns/iter (± 48) 1246 ns/iter (± 1) 0.76
misc/visitors/time-complexity/time 40 3740 ns/iter (± 211) 6274 ns/iter (± 2) 0.60
misc/visitors/time-complexity/time 60 7749 ns/iter (± 14) 15816 ns/iter (± 49) 0.49
es/full-target/es2016 242987 ns/iter (± 871) 272260 ns/iter (± 615) 0.89
es/full-target/es2017 228861 ns/iter (± 616) 261596 ns/iter (± 685) 0.87
es/full-target/es2018 217108 ns/iter (± 1633) 250372 ns/iter (± 383) 0.87
es2020_nullish_coalescing 71301 ns/iter (± 234) 99194 ns/iter (± 458) 0.72
es2020_optional_chaining 62906 ns/iter (± 229) 88700 ns/iter (± 280) 0.71
es2022_class_properties 119323 ns/iter (± 208) 158329 ns/iter (± 470) 0.75
es2018_object_rest_spread 75671 ns/iter (± 346) 101159 ns/iter (± 226) 0.75
es2019_optional_catch_binding 64353 ns/iter (± 252) 88942 ns/iter (± 497) 0.72
es2017_async_to_generator 64441 ns/iter (± 217) 89777 ns/iter (± 171) 0.72
es2016_exponentiation 69604 ns/iter (± 235) 96665 ns/iter (± 273) 0.72
es2015_arrow 72366 ns/iter (± 170) 99518 ns/iter (± 250) 0.73
es2015_block_scoped_fn 69689 ns/iter (± 215) 97457 ns/iter (± 327) 0.72
es2015_block_scoping 132576 ns/iter (± 372) 184739 ns/iter (± 288) 0.72

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.