-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bundler #1246
Merged
Merged
Fix bundler #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swc_bundler:
deno bundle
denoland/deno#8574)await
s in wrapped modules. (bundler fails on top level await inexport * as log
re-exported module denoland/deno#8584)Single thread benchmark result: (osx, system allocator)
three.js
: 637,085,626 ns/iter = 0.637 s/iter.Single thread benchmark result: (osx, jemalloc)
three.js
: 418,903,689 ns/iter = 0.418 s/iter.My MBP Spec:
I also tested jemalloc version because jemalloc tends to make huge difference for swc on mac.
Postponing denoland/deno#8545 because I guess it to take some time to fix, thus separate pr would be better.