Fix bug when resolving file names with a period. #1748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `with_extension()` on file names that contained a period would truncate the name causing module resolution to fail. This also includes the `resolve-name-fix` test case using a specific version of `core-js` that is a real-world library using periods in file names and referencing imports without an explicit extension.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
with_extension()on file names that contained a period wouldtruncate the name causing module resolution to fail.
This also includes the
resolve-name-fixtest case using a specificversion of
core-jsthat is a real-world library using periods in filenames and referencing imports without an explicit extension.