Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/minifier): Fix for @emotion/react and murmur2 #2637

Merged
merged 22 commits into from
Nov 3, 2021

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Nov 3, 2021

swc_ecma_minifier:

  • Check for the operator while folding binary assignments.
  • sequences: More check before inlining into operator assignments.

Related: vercel/next.js#30237 (comment)

@kdy1 kdy1 added this to the v1.2.107 milestone Nov 3, 2021
@kdy1 kdy1 changed the title fix(es/minifier): Fix for @emotion/react fix(es/minifier): Fix for @emotion/react / murmur2 Nov 3, 2021
@kdy1 kdy1 marked this pull request as ready for review November 3, 2021 11:38
@kdy1 kdy1 changed the title fix(es/minifier): Fix for @emotion/react / murmur2 fix(es/minifier): Fix for @emotion/react and murmur2 Nov 3, 2021
@kdy1 kdy1 merged commit 808d578 into swc-project:master Nov 3, 2021
@kdy1 kdy1 deleted the minifier-2 branch November 3, 2021 13:46
@kdy1 kdy1 mentioned this pull request Nov 3, 2021
10 tasks
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Nov 3, 2021
## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`


This applies

 - swc-project/swc#2637

This makes inlining not work for more cases, and fixes `@emotion/react` and `murmur2`.
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`


This applies

 - swc-project/swc#2637

This makes inlining not work for more cases, and fixes `@emotion/react` and `murmur2`.
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant