Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetterProp - Add type_ann #557

Merged
merged 4 commits into from
Jan 3, 2020
Merged

Conversation

dsherret
Copy link
Contributor

@dsherret dsherret commented Jan 3, 2020

Adds parsing of a type annotation to GetterProp.

This is valid typescript:

const obj = {
    get test() : string {
        return "";
    }
};

https://www.typescriptlang.org/play/?ssl=5&ssc=3&pln=1&pc=1#code/MYewdgzgLgBCBGArGBeGBvAsAKBnmA5gKaxRHQAUAlDAFwzQBOAlmARjvlzIyQK6MwMAETCA3J3wBfHFLFA

@kdy1
Copy link
Member

kdy1 commented Jan 3, 2020

The pr seems good to me, but I expect swc_ecma_transforms to be broken.

Can you give me a permission to push to your fork? I'm asking this as I don't like breaking master branch. (Although tracis ci fails, I always check that all tests passes locally)

@dsherret
Copy link
Contributor Author

dsherret commented Jan 3, 2020

@kdy1 that would be great! I believe you already have permission. to push to my fork. Thanks and no rush!

@kdy1
Copy link
Member

kdy1 commented Jan 3, 2020

@dsherret I didn't know that I have push permission on fork. I fixed swc_ecma_transforms and verified that all tests pass.

@kdy1 kdy1 merged commit 5acf557 into swc-project:master Jan 3, 2020
@kdy1 kdy1 added this to the v1.1.12 milestone Jan 3, 2020
@kdy1 kdy1 self-assigned this Jan 3, 2020
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants