fix(es/base): Remove unnecessary parameters in helper_expr macro #7296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was thinking something similar. Given that we now process it via a script, I think we can update inline helpers by running a script, too. |
magic-akari
commented
Apr 19, 2023
| @@ -1,4 +1,4 @@ | |||
| var __decorate = (this && this.__decorate) || function (decorators, target, key, desc) { | |||
| var _ts_decorate = (this && this._ts_decorate) || function (decorators, target, key, desc) { | |||
There was a problem hiding this comment.
I found that I had to change export name in order to make the ts inline helpers work.
From my personal opinion, I don't particularly like this change. It makes our code look different from the ts helpers.
There was a problem hiding this comment.
I agree witg you, but the problem was the SyntaxContext
kdy1
approved these changes
Apr 20, 2023
swc-bot
reviewed
Apr 20, 2023
swc-bot
reviewed
Apr 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We have move to snake_case, so the last parameter of helper_expr is unnecessary.
next step:
We have a copy of the swc/helpers directory in the swc_ecma_transforms_base directory, which has a subtle difference.
It is used for inline helpers.
Currently, it is manually maintained. Can it be generated automatically?
BREAKING CHANGE:
Related issue (if exists):