Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(es/lexer): Remove needless clones of Rc<RefCell<AtomStore>> #8231

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

dsherret
Copy link
Contributor

@dsherret dsherret commented Nov 7, 2023

Removes some clones of self.atom.

> cargo "bench" "--package" "swc_ecma_parser" "--bench" "parser" "--" "three"

Main: ~38.2ms
This PR: ~37.8ms

@kdy1 kdy1 changed the title perf(lexer): remove some clones of Rc<RefCell<AtomStore>> perf(es/lexer): Remove needless clones of Rc<RefCell<AtomStore>> Nov 7, 2023
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_parser

@kdy1 kdy1 enabled auto-merge (squash) November 7, 2023 08:51
@kdy1 kdy1 merged commit 37657b8 into swc-project:main Nov 7, 2023
141 of 143 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.3.97 Nov 7, 2023
@kdy1 kdy1 modified the milestones: Planned, v1.3.97 Nov 20, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants